lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2438) BytesRef improvements
Date Mon, 03 May 2010 17:41:56 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863422#action_12863422
] 

Yonik Seeley commented on LUCENE-2438:
--------------------------------------

Another issue is that it looks like some code assumes that offset==0 (and this is reinforced
by the naming of BytesRef.length, which we should consider changing to BytesRef.len)

Most of these seem sort-of OK... it's after a UTF16TOUTF8, which always makes the offset zero.
 But if we depend on this, it should be documented.

For example:
org.apache.lucene.document.CompressionTools#compressString
org.apache.lucene.index.codecs.pulsing.PulsingPostingsWriterImpl#finishTerm
org.apache.lucene.store.DataOutput#writeString

> BytesRef improvements
> ---------------------
>
>                 Key: LUCENE-2438
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2438
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0.0
>            Reporter: Yonik Seeley
>         Attachments: LUCENE-2438.patch, LUCENE-2438.patch, LUCENE-2438.patch
>
>
> Make BytesRef comparable, document that byte[] should not be null, remove explicit null
check + allocation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message