lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lance Norskog (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1013) Scan code for equality implementation mistakes
Date Sat, 08 May 2010 22:18:48 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865508#action_12865508
] 

Lance Norskog commented on SOLR-1013:
-------------------------------------

Please close this. On further study of this particular nit, the reporter's opinion is that
Query classes should be done as immutable objects.

> Scan code for equality implementation mistakes
> ----------------------------------------------
>
>                 Key: SOLR-1013
>                 URL: https://issues.apache.org/jira/browse/SOLR-1013
>             Project: Solr
>          Issue Type: Task
>    Affects Versions: 1.3
>            Reporter: Lance Norskog
>            Priority: Minor
>             Fix For: 1.5
>
>
> In  SolrIndexSearcher.java:getDocSet() we find 'absQ==query'. The Query classes have
equals & hashcode implementations. This code apparently works now, but all of the code
should use equals&hashcode instead of '=='.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message