lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2458) queryparser makes all CJK queries phrase queries regardless of analyzer
Date Fri, 28 May 2010 16:01:45 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873025#action_12873025
] 

Robert Muir commented on LUCENE-2458:
-------------------------------------

{quote}
The easiest way might be to just make it configurable per-parser but changeable at any point
in time (i.e. just a getter and a setter).
Per-field can be handled via subclassing (same way per-field differences are handled for everything
else with this QP).
{quote}

True, but I thought there was something about dealing with this via subclassing you didnt
like?

With the current patch (with no option at all) you could do this per-field behavior with subclassing
already:

{code}
@Override
public Query getFieldQuery(String field, String text, boolean quoted) {
 if (field.equals("foobar"))
   return super.getFieldQuery(field, text, true /* treat it as if it were quoted */ );
 else
  return super.getFieldQuery(field, text, quoted);
}
{code}


> queryparser makes all CJK queries phrase queries regardless of analyzer
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-2458
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2458
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: QueryParser
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Blocker
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2458.patch, LUCENE-2458.patch, LUCENE-2458.patch
>
>
> The queryparser automatically makes *ALL* CJK, Thai, Lao, Myanmar, Tibetan, ... queries
into phrase queries, even though you didn't ask for one, and there isn't a way to turn this
off.
> This completely breaks lucene for these languages, as it treats all queries like 'grep'.
> Example: if you query for f:abcd with standardanalyzer, where a,b,c,d are chinese characters,
you get a phrasequery of "a b c d". if you use cjk analyzer, its no better, its a phrasequery
of  "ab bc cd", and if you use smartchinese analyzer, you get a phrasequery like "ab cd".
But the user didn't ask for one, and they cannot turn it off.
> The reason is that the code to form phrase queries is not internationally appropriate
and assumes whitespace tokenization. If more than one token comes out of whitespace delimited
text, its automatically a phrase query no matter what.
> The proposed patch fixes the core queryparser (with all backwards compat kept) to only
form phrase queries when the double quote operator is used. 
> Implementing subclasses can always extend the QP and auto-generate whatever kind of queries
they want that might completely break search for languages they don't care about, but core
general-purpose QPs should be language independent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message