lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-2389) Enforce TokenStream impl / Analyzer finalness by an assertion
Date Tue, 04 May 2010 12:48:58 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler updated LUCENE-2389:
----------------------------------

    Fix Version/s: 4.0.0

> Enforce TokenStream impl / Analyzer finalness by an assertion
> -------------------------------------------------------------
>
>                 Key: LUCENE-2389
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2389
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.1, 4.0.0
>
>         Attachments: LUCENE-2389.patch, LUCENE-2389.patch
>
>
> As noted in LUCENE-1753 and other issues, TokenStream and Analyzers are based on the
decorator pattern. At least all TokenStream and Analyzer implementations in Lucene and Solr
should be final.
> The attached patch adds an assertion to the ctors of both classes that does the corresponding
checks:
> - Analyzers must be final or private classes or anonymous inner classes
> - TokenStreams must be final or private classes or anonymous inner classes or have a
final incrementToken()
> I will commit this after robert have fixed solr streams.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message