lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Earwin Burrfoot (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2480) Remove support for pre-3.0 indexes
Date Sun, 30 May 2010 18:35:36 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873469#action_12873469
] 

Earwin Burrfoot commented on LUCENE-2480:
-----------------------------------------

bq. Strange, there were lines in my patch file which indicated they are removed, but were
absent from yours.
{code}
Index: lucene/src/test/org/apache/lucene/index/index.19.cfs.zip
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: lucene/src/test/org/apache/lucene/index/index.19.nocfs.zip
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: lucene/src/test/org/apache/lucene/index/index.20.cfs.zip
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
{code}
These lines in your patch mean that diff noticed the differences, but failed to express them
- nothing more. You could modify all these files instead of deleting, and get the same result.

bq. I don't see it.
Ctrl+F, "testCreateCFS"
Ok, they're not completely identical. But I don't really care either way.

bq. .... FORMAT stuff .....
Ok.

> Remove support for pre-3.0 indexes
> ----------------------------------
>
>                 Key: LUCENE-2480
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2480
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2480.patch, LUCENE-2480.patch, LUCENE-2480.patch, LUCENE-2480.patch
>
>
> We should remove support for 2.x (and 1.9) indexes in 4.0. It seems that nothing can
be done in 3x because there is no special code which handles 1.9, so we'll leave it there.
This issue should cover:
> # Remove the .zip indexes
> # Remove the unnecessary code from SegmentInfo and SegmentInfos. Mike suggests we compare
the version headers at the top of SegmentInfos, in 2.9.x vs 3.0.x, to see which ones can go.
> # remove FORMAT_PRE from FieldInfos
> # Remove old format from TermVectorsReader
> If you know of other places where code can be removed, then please post a comment here.
> I don't know when I'll have time to handle it, definitely not in the next few days. So
if someone wants to take a stab at it, be my guest.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message