lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2453) Make Index Output Buffer Size Configurable
Date Mon, 10 May 2010 07:33:49 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865688#action_12865688
] 

Shai Erera commented on LUCENE-2453:
------------------------------------

Patch looks good ! Few comments:
* buffer can still be final (and should) since it's only initialized in the ctor
* I'd inline checkBufferSize in the ctor
* I think that adding the same level of control to BufferedIndexInput would be useful too?

In general, I think the size of the buffer (1024) is set like that because larger buffer sizes
did not improve the performance. Can you perhaps run on the benchmark indexing algorithms,
w/ the buffer size set to larger values and report the results? It'd be interesting to note
if there are any improvements before we open up the API like that.

> Make Index Output Buffer Size Configurable
> ------------------------------------------
>
>                 Key: LUCENE-2453
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2453
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Store
>    Affects Versions: 3.0.1
>            Reporter: Karthick Sankarachary
>         Attachments: LUCENE-2453.patch
>
>
> Currently, the buffered index input class allows sub-classes and users thereof to specify
a size for the input buffer, which by default is 1024 bytes. In practice, this option is leveraged
by the simple file and compound segment index input sub-classes. 
> By the same token, it would be nice if the buffered index output class could open up
it's buffer size for users to configure. In particular, this would allow sub-classes thereof
to align the output buffer size, which by default is 16348 bytes, to that of the underlying
directory's data unit. For example, a network-based directory might want to buffer data in
multiples of it's maximum transmission unit. To use an existing use-case, the file system-based
directory could potentially choose to align it's output buffer size to the operating system's
file block size.
> The proposed change to the buffered index output class involves defining a one-arg constructor
that takes a user-defined buffer size, and a default constructor that uses the currently defined
buffer size.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message