lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-2468) reopen on NRT reader should share readers w/ unchanged segments
Date Tue, 18 May 2010 23:46:57 GMT


Michael McCandless commented on LUCENE-2468:

bq. Basically, it does not work with your change and it using a cached filter.

I'm still confused :)  My patch has your test case (which uses ConstantScoreQuery).  I tweaked
the test case a bit, eg to not rely on TermsFilter (which is in contrib).

The test failed when I first made the change (as expected).

Then I modified CachingWrapperFilter to take the optional boolean "enforceDeletions".

Then I changed the test to pass "true" for enforceDeletions, and the test now passes.

I don't think any change is needed to ConstantScoreQuery?  (Ie, I took the "less invasive"
option in my comment above).

> reopen on NRT reader should share readers w/ unchanged segments
> ---------------------------------------------------------------
>                 Key: LUCENE-2468
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Assignee: Michael McCandless
>         Attachments:, LUCENE-2468.patch, LUCENE-2468.patch
> A repoen on an NRT reader doesn't seem to share readers for those segments that are unchanged.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message