lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2480) Remove support for pre-3.0 indexes
Date Sun, 30 May 2010 18:19:36 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873466#action_12873466
] 

Shai Erera commented on LUCENE-2480:
------------------------------------

bq. Your patch didn't remove them for me, patch file format can't handle binary stuff.

Strange, there were lines in my patch file which indicated they are removed, but were absent
from yours. Anyway, they're removed now.

bq. Several lines later there sits a piece of absolutely identical commented-out code. 

I don't see it.  All I see is a comment and two methods that are used to generate the old
indexes.

bq. FORMAT_4_0_FLEX_POSTINGS

While I don't mind that sort of descriptiveness, it does not fit in all cases, such as this
case -- this format is related to both flex postings, but also to that byte removed from the
SegmentInfo :). So I think we should keep the names simple, and have a useful javadoc. It's
the sort of constants no one really cares about in his daily work, only when you handle file
format backwards stuff :).

Also, if by chance (like this case, again) you get to change the file format version twice,
by two different people, with long time interval between the two, a FORMAT_4_0 should alert
you that that's used for the unreleased index, and so you don't need to bump it up again (here,
jumping from -9 to -11) accidentally.

> Remove support for pre-3.0 indexes
> ----------------------------------
>
>                 Key: LUCENE-2480
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2480
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2480.patch, LUCENE-2480.patch, LUCENE-2480.patch, LUCENE-2480.patch
>
>
> We should remove support for 2.x (and 1.9) indexes in 4.0. It seems that nothing can
be done in 3x because there is no special code which handles 1.9, so we'll leave it there.
This issue should cover:
> # Remove the .zip indexes
> # Remove the unnecessary code from SegmentInfo and SegmentInfos. Mike suggests we compare
the version headers at the top of SegmentInfos, in 2.9.x vs 3.0.x, to see which ones can go.
> # remove FORMAT_PRE from FieldInfos
> # Remove old format from TermVectorsReader
> If you know of other places where code can be removed, then please post a comment here.
> I don't know when I'll have time to handle it, definitely not in the next few days. So
if someone wants to take a stab at it, be my guest.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message