lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2468) reopen on NRT reader should share readers w/ unchanged segments
Date Wed, 19 May 2010 18:05:01 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869233#action_12869233
] 

Michael McCandless commented on LUCENE-2468:
--------------------------------------------

bq. Here is a go at making ConstantScoreQuery deletion aware. I named it differently, but
it can replace ConstantScoreQuery with a flag making it deletion aware. What do you think?

I don't think we need to fix ConstantScoreQuery to be deletions
aware?

With the perf fix we are doing here, the problem (not correctly
"seeing" deletes on a reopened reader) is isolated to
CachingWrapperFilter/CachingSpanFilter, right?

Why fix ConstantScoreQuery, when so many other Filter impls will
properly apply deletions?


> reopen on NRT reader should share readers w/ unchanged segments
> ---------------------------------------------------------------
>
>                 Key: LUCENE-2468
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2468
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Assignee: Michael McCandless
>         Attachments: CacheTest.java, DeletionAwareConstantScoreQuery.java, LUCENE-2468.patch,
LUCENE-2468.patch
>
>
> A repoen on an NRT reader doesn't seem to share readers for those segments that are unchanged.
> http://search.lucidimagination.com/search/document/9f0335d480d2e637/nrt_and_caching_based_on_indexreader

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message