Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 72760 invoked from network); 20 Apr 2010 00:56:56 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 20 Apr 2010 00:56:56 -0000 Received: (qmail 20351 invoked by uid 500); 20 Apr 2010 00:56:55 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 20146 invoked by uid 500); 20 Apr 2010 00:56:55 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 20139 invoked by uid 99); 20 Apr 2010 00:56:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Apr 2010 00:56:54 +0000 X-ASF-Spam-Status: No, hits=0.7 required=10.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [209.85.210.179] (HELO mail-yx0-f179.google.com) (209.85.210.179) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Apr 2010 00:56:48 +0000 Received: by yxe9 with SMTP id 9so3241146yxe.29 for ; Mon, 19 Apr 2010 17:56:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.190.12 with HTTP; Mon, 19 Apr 2010 17:56:26 -0700 (PDT) In-Reply-To: References: Date: Mon, 19 Apr 2010 20:56:26 -0400 Received: by 10.150.118.3 with SMTP id q3mr173509ybc.211.1271724986930; Mon, 19 Apr 2010 17:56:26 -0700 (PDT) Message-ID: Subject: Re: Fix to contrib/misc/HighFreqTerms.java From: Michael McCandless To: dev@lucene.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Thanks Tom! On Mon, Apr 19, 2010 at 4:27 PM, Burton-West, Tom wrote: > Ok opened LUCENE-2403. > > I could make the change to make the two lines consistent but to use a BytesRef directly wouldn't Term.java need to use BytesRef instead of String, or is there a new flex "Term" class that uses a BytesRef to use? There is no Term class that takes a BytesRef... other things need this, too (eg TermQuery needs to accept a BytesRef). But we are considering deprecating Term entirely (it's not used in that many further places). > Otherwise, TermInfo could change to use the name of the field and a BytesRef instead of a term. +1 -- I think we should take this approach? Mike --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org