Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 56726 invoked from network); 23 Apr 2010 12:37:24 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 23 Apr 2010 12:37:24 -0000 Received: (qmail 85608 invoked by uid 500); 23 Apr 2010 12:37:23 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 85556 invoked by uid 500); 23 Apr 2010 12:37:23 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 85549 invoked by uid 500); 23 Apr 2010 12:37:23 -0000 Delivered-To: apmail-lucene-java-dev@lucene.apache.org Received: (qmail 85546 invoked by uid 99); 23 Apr 2010 12:37:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Apr 2010 12:37:23 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Apr 2010 12:37:21 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o3NCaxi9009847 for ; Fri, 23 Apr 2010 12:37:00 GMT Message-ID: <10843501.160341272026219594.JavaMail.jira@thor> Date: Fri, 23 Apr 2010 08:36:59 -0400 (EDT) From: "Robert Muir (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-2415) Remove JakarteRegExCapabilities shim to access package protected field In-Reply-To: <33405145.160161272025010881.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860237#action_12860237 ] Robert Muir commented on LUCENE-2415: ------------------------------------- +1 > Remove JakarteRegExCapabilities shim to access package protected field > ---------------------------------------------------------------------- > > Key: LUCENE-2415 > URL: https://issues.apache.org/jira/browse/LUCENE-2415 > Project: Lucene - Java > Issue Type: Improvement > Components: contrib/* > Reporter: Uwe Schindler > Assignee: Uwe Schindler > Fix For: 3.1 > > Attachments: LUCENE-2415.patch > > > To access the prefix in Jakarta RegExes we use a shim class in the same package as jakarta. I will remove this and replace by reflection like Robert does in his ICUTokenizer rule compiler. > Shim classes have the problem wth signed artifacts, as you cannot insert a new class into a foreign package if you sign regex classes. > This shim-removal also allows users to use later jakarta regex versions, if they are in classpath and cannot be removed (even if they have bugs). Performance is no problem, as the prefix is only get once per TermEnum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org