He answered on the JIRA topic as well.

Regards,

Nicolas

2010/4/1 Grant Ingersoll <gsingers@apache.org>

On Mar = 31, 2010, at 6:08 PM, Helleringer, Nicolas wrote:

I do.

It is clearly related to prime meridian = handling but it is unreadable and buggy.

Yeah, I put up and committed a bunch= of comments. =A0

I did a complete rewrite of this sector of code commited to= Chris Male repository (working together to rework the whole thing).

I put up a patch on=A0https://i= ssues.apache.org/jira/browse/LUCENE-2359. =A0How does your's compar= e? =A0Can you post it?

Commit of this work should be done by Chris very soon.<= /div>

Hope it will help.

Nicola= s

2010/3/31 Grant Ingersoll
Anyone know what the point of this code is f= rom the CartesianPolyFilterBuilder:

<code>
=A0 =A0shape =3D getShapeLoop(shape, ctp, latX, longX, latY, longY);
=A0 =A0if (longX2 !=3D 0.0) {
=A0 =A0 =A0if (longX2 !=3D 0.0) {
=A0 =A0 =A0 =A0if (longX =3D=3D 0.0) {
=A0 =A0 =A0 =A0 =A0longX =3D longX2;
=A0 =A0 =A0 =A0 =A0longY =3D 0.0;
=A0 =A0 =A0 =A0 =A0shape =3D getShapeLoop(shape, ctp, latX, longX, latY, l= ongY);
=A0 =A0 =A0 =A0} else {
=A0 =A0 =A0 =A0 =A0longX =3D longX2;
=A0 =A0 =A0 =A0 =A0longY =3D -180.0;
=A0 =A0 =A0 =A0 =A0shape =3D getShapeLoop(shape, ctp, latY, longY, latX, l= ongX);
=A0 =A0 =A0 =A0}
=A0 =A0 =A0}

</code>

Why the double check on longX2? =A0I think it's trying to get at edge c= ases (based on earlier statements to do with prime meridian and the 180 lon= gitude.

Also, I see the following comment:
double startY =3D beginAt - startX ; //should give a whole number

Yet, in debugging, I don't see how it is ever a whole number, b/c, AIUI= , the left side of the decimal of a box number is the X value (latitude) an= d the right side of the decimal is the Y value.

FWIW, I'm testing how all this tile stuff behaves across the 180th degr= ee longitude (and it doesn't seem to be behaving well)

-Grant
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org