lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2422) don't reuse byte[] in IndexInput/Output for read/writeString
Date Fri, 30 Apr 2010 04:24:54 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862530#action_12862530
] 

Shai Erera commented on LUCENE-2422:
------------------------------------

Mike - this patch is against an old revision? I'm up to the latest and IndexInput/Output don't
include any field, just abstract methods. This seems to be relevant to 3.0.1 (and before?)
If so, where does this need to be fixed post 3.0.1?

> don't reuse byte[] in IndexInput/Output for read/writeString
> ------------------------------------------------------------
>
>                 Key: LUCENE-2422
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2422
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 2.9.3, 3.0.2, 3.1, 4.0.0
>
>         Attachments: LUCENE-2422.patch
>
>
> IndexInput now holds a private "byte[] bytes", which it re-uses for reading strings.
 Likewise, IndexOutput holds a UTF8Result (which holds "byte[] bytes"), re-used for writing
strings.
> These are both dangerous, since on reading or writing immense strings, we never free
this storage.
> We don't use read/writeString in very perf sensitive parts of the code, so, I think we
should not reuse the byte[] at all.
> I think this is likely the cause of the recent "IndexWriter and memory usage" thread,
started by Ross Woolf on java-user@.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message