lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] Created: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory
Date Thu, 08 Apr 2010 19:47:37 GMT
IndexWriter commits unnecessarily on fresh Directory

                 Key: LUCENE-2386
             Project: Lucene - Java
          Issue Type: Bug
          Components: Index
            Reporter: Shai Erera
            Assignee: Shai Erera
             Fix For: 3.1

I've noticed IndexWriter's ctor commits a first commit (empty one) if a fresh Directory is
passed, w/ OpenMode.CREATE or CREATE_OR_APPEND. This seems unnecessarily, and kind of brings
back an autoCommit mode, in a strange way ... why do we need that commit? Do we really expect
people to open an IndexReader on an empty Directory which they just passed to an IW w/ create=true?
If they want, they can simply call commit() right away on the IW they created.

I ran into this when writing a test which committed N times, then compared the number of commits
(via IndexReader.listCommits) and was surprised to see N+1 commits.

Tried to change doCommit to false in IW ctor, but it got IndexFileDeleter jumping on me ..
so the change might not be that simple. But I think it's manageable, so I'll try to attack
it (and IFD specifically !) back :).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message