lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Created: (LUCENE-2389) Enforce TokenStream impl / Analyzer finalness by an assertion
Date Sat, 10 Apr 2010 18:00:51 GMT
Enforce TokenStream impl / Analyzer finalness by an assertion
-------------------------------------------------------------

                 Key: LUCENE-2389
                 URL: https://issues.apache.org/jira/browse/LUCENE-2389
             Project: Lucene - Java
          Issue Type: Improvement
            Reporter: Uwe Schindler
            Assignee: Uwe Schindler


As noted in LUCENE-1753 and other issues, TokenStream and Analyzers are based on the decorator
pattern. At least all TokenStream and Analyzer implementations in Lucene and Solr should be
final.

The attached patch adds an assertion to the ctors of both classes that does the corresponding
checks:
- Analyzers must be final or private classes or anonymous inner classes
- TokenStreams must be final or private classes or anonymous inner classes or have a final
incrementToken()

I will commit this after robert have fixed solr streams.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message