lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Helleringer (JIRA)" <>
Subject [jira] Commented: (LUCENE-2366) LLRect.createBox returned box does not contains all points in (center,distance) disc
Date Tue, 06 Apr 2010 11:14:37 GMT


Nicolas Helleringer commented on LUCENE-2366:

I reviewed the code as it still raise an error in the TestCartesian.testAntiM

In fact the error is coming from 

    double startX = beginAt - (beginAt %1);
    double startY = beginAt - startX ; //should give a whole number
    double endX = endAt - (endAt %1);
    double endY = endAt -endX; //should give a whole number

@ CartesianPolyFilterBuilder.getShapeLoop : the double handling that should give a whole number
does not.

If you pass my version of LUCENE-2359 that does not rely on this code anymore everything is

> LLRect.createBox returned box does not contains all points in (center,distance) disc
> ------------------------------------------------------------------------------------
>                 Key: LUCENE-2366
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/spatial
>    Affects Versions: 3.0.1
>            Reporter: Nicolas Helleringer
>         Attachments: LUCENE-2366.patch, LUCENE-2366.patch, LUCENE-2366.patch
>   Original Estimate: 4h
>  Remaining Estimate: 4h
> LLRect,createBox computation of a bouding box for a disc given center and distance doest
not contains all the point in the distance.
> Example : the point north by distance doest not have Lat inferior of Lat of the UpperRight
corner of the returned box

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message