lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Calderon (JIRA)" <j...@apache.org>
Subject [jira] Closed: (SOLR-1869) RemoveDuplicatesTokenFilter doest have expected behaviour
Date Thu, 22 Apr 2010 21:12:50 GMT

     [ https://issues.apache.org/jira/browse/SOLR-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Joe Calderon closed SOLR-1869.
------------------------------

    Resolution: Not A Problem

im closing this since there is no bug in RemoveDuplicates filter, will post another patch
in another ticker if i ever get around to patching the highlighter

> RemoveDuplicatesTokenFilter doest have expected behaviour
> ---------------------------------------------------------
>
>                 Key: SOLR-1869
>                 URL: https://issues.apache.org/jira/browse/SOLR-1869
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>            Reporter: Joe Calderon
>            Priority: Minor
>         Attachments: RemoveDupOffsetTokenFilter.java, RemoveDupOffsetTokenFilterFactory.java,
SOLR-1869.patch
>
>
> the RemoveDuplicatesTokenFilter seems broken as it initializes its map and attributes
at the class level and not within its constructor
> in addition i would think the expected behaviour would be to remove identical terms with
the same offset positions, instead it looks like it removes duplicates based on position increment
which wont work when using it after something like the edgengram filter. when i posted this
to the mailing list even erik hatcher seemed to think thats what this filter was supposed
to do...
> attaching a patch that has the expected behaviour and initializes variables in constructor

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message