lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Burton-West (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2353) Config incorrectly handles Windows absolute pathnames
Date Wed, 07 Apr 2010 15:58:33 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854566#action_12854566
] 

Tom Burton-West commented on LUCENE-2353:
-----------------------------------------

Shai,

I am having the same issue with the test hanging on my Windows box with both Revision 931573
and Revision   931304 when running the tests from root.

Tests hang in WriteLineDocTaskTest, on this line:
[junit] ------------> config properties:
[junit] directory = RAMDirectory
[junit] doc.maker = org.apache.lucene.benchmark.byTask.tasks.WriteLineDocTaskTest$JustDateDocMaker
[junit] line.file.out = D:\dev\lucene\lucene-trunk\build\contrib\benchmark\test\W\one-line
[junit] -------------------------------

Should I open a separate JIRA issue about the test?

Tom Burton-West

> Config incorrectly handles Windows absolute pathnames
> -----------------------------------------------------
>
>                 Key: LUCENE-2353
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2353
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>             Fix For: 3.1
>
>         Attachments: LUCENE-2353.patch, LUCENE-2353.patch
>
>
> I have no idea how no one ran into this so far, but I tried to execute an .alg file which
used ReutersContentSource and referenced both docs.dir and work.dir as Windows absolute pathnames
(e.g. d:\something). Surprisingly, the run reported an error of missing content under benchmark\work\something.
> I've traced the problem back to Config, where get(String, String) includes the following
code:
> {code}
>     if (sval.indexOf(":") < 0) {
>       return sval;
>     }
>     // first time this prop is extracted by round
>     int k = sval.indexOf(":");
>     String colName = sval.substring(0, k);
>     sval = sval.substring(k + 1);
>     ...
> {code}
> It detects ":" in the value and so it thinks it's a per-round property, thus stripping
"d:" from the value ... fix is very simple:
> {code}
>     if (sval.indexOf(":") < 0) {
>       return sval;
>     } else if (sval.indexOf(":\\") >= 0) {
>       // this previously messed up absolute path names on Windows. Assuming
>       // there is no real value that starts with \\
>       return sval;
>     }
>     // first time this prop is extracted by round
>     int k = sval.indexOf(":");
>     String colName = sval.substring(0, k);
>     sval = sval.substring(k + 1);
> {code}
> I'll post a patch w/ the above fix + test shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message