lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] Commented: (SOLR-571) LRUCache autowarmCount should support percentages
Date Thu, 29 Apr 2010 18:48:54 GMT


Hoss Man commented on SOLR-571:

bq. Since this was my first patch for Solr, I didn't want to modify too much code just for
a little functional change. 

Your instincts were correct -- patches should try to remain focused, so a major refactoring
of the two classes would have confused the issue, but if you find yourself adding the same
method to two different classes in a patch, refactoring it into a utility method to make it
clear to the patch reader that the functionality really is identical is a good idea -- it
helps point the way to subsequent refactorings (like the super class i added).

> LRUCache autowarmCount should support percentages
> -------------------------------------------------
>                 Key: SOLR-571
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>             Fix For: 1.5
>         Attachments: SOLR-571.patch, SOLR-571.patch
> a recent thread reminded me of an old idea that never got implemented...
> the autowarmCount for LRUCaches should support "percentages" which get evaluated relative
the current size of the cache when warming happens.  
> in this way, a Solr instance might be configured with autowarmCount="50%" to autowarm
the top half of the queries ... a master machine might be configured this way to give some
autowarming if it is inadvertently being queried, but things won't be maintained in the caches
in perpetuity ... each subsequent cache instance would have fewer and fewer of the "old" queries
warmed automatically.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message