Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 34903 invoked from network); 28 Mar 2010 13:15:52 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 28 Mar 2010 13:15:52 -0000 Received: (qmail 93994 invoked by uid 500); 28 Mar 2010 13:15:51 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 93922 invoked by uid 500); 28 Mar 2010 13:15:50 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 93915 invoked by uid 99); 28 Mar 2010 13:15:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Mar 2010 13:15:50 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Mar 2010 13:15:48 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 25CCF234C495 for ; Sun, 28 Mar 2010 13:15:27 +0000 (UTC) Message-ID: <951778143.534881269782127140.JavaMail.jira@brutus.apache.org> Date: Sun, 28 Mar 2010 13:15:27 +0000 (UTC) From: "Uwe Schindler (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Assigned: (LUCENE-2315) AttributeSource's methods for accessing attributes should be final, else its easy to corrupt the internal states In-Reply-To: <280445305.244291268480367118.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-2315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reassigned LUCENE-2315: ------------------------------------- Assignee: Uwe Schindler > AttributeSource's methods for accessing attributes should be final, else its easy to corrupt the internal states > ---------------------------------------------------------------------------------------------------------------- > > Key: LUCENE-2315 > URL: https://issues.apache.org/jira/browse/LUCENE-2315 > Project: Lucene - Java > Issue Type: Bug > Affects Versions: 2.9, 2.9.1, 2.9.2, 3.0, 3.0.1 > Reporter: Uwe Schindler > Assignee: Uwe Schindler > Priority: Minor > Fix For: 3.1 > > > The methods that operate and modify the internal maps of AttributeSource should be final, which is a backwards break. But anybody that overrides such methods simply creates a buggy AS either case. > I want to makeall impls final (in general the class should be final at all, but it is made for extension in TokenStream). So its important that the implementations are final! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org