Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Message-ID: <356743251.178161268235087172.JavaMail.jira@brutus.apache.org>
Date: Wed, 10 Mar 2010 15:31:27 +0000 (UTC)
From: "Robert Muir (JIRA)" <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Commented: (LUCENE-2015) ASCIIFoldingFilter: expose folding
 logic + small improvements to ISOLatin1AccentFilter
In-Reply-To: <1166542840.1256835779760.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/LUCENE-2015?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D128=
43593#action_12843593 ]=20

Robert Muir commented on LUCENE-2015:
-------------------------------------

Thanks C=C3=A9drik, I like your latest change.

My primary reasoning for minimizing the API is because each exposed=20
method has some cost to us (backwards compatibility).

I think if someone wants to fold a String they can still work with this API=
,
e.g. use a char[1] container, and not even bother if charAt() < 0x7F, etc.

In general I guess i am less concerned about this as the Lucene API=20
doesn't use String.

I will commit in a day or two if no one objects.


> ASCIIFoldingFilter: expose folding logic + small improvements to ISOLatin=
1AccentFilter
> -------------------------------------------------------------------------=
-------------
>
>                 Key: LUCENE-2015
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2015
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: C=C3=A9drik LIME
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: ASCIIFoldingFilter-no_formatting.patch, ASCIIFolding=
Filter-no_formatting.patch, Filters.patch, ISOLatin1AccentFilter.patch, LUC=
ENE-2015.patch, LUCENE-2015.patch
>
>
> This patch adds a couple of non-ascii chars to ISOLatin1AccentFilter (nam=
ely: left & right single quotation marks, en dash, em dash) which we very f=
requently encounter in our projects. I know that this class is now deprecat=
ed; this improvement is for legacy code that hasn't migrated yet.
> It also enables easy access to the ascii folding technique use in ASCIIFo=
ldingFilter for potential re-use in non-Lucene-related code.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org