From java-dev-return-47219-apmail-lucene-java-dev-archive=lucene.apache.org@lucene.apache.org Mon Mar 01 08:53:06 2010 Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 19594 invoked from network); 1 Mar 2010 08:53:06 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 1 Mar 2010 08:53:06 -0000 Received: (qmail 64513 invoked by uid 500); 28 Feb 2010 11:06:26 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 64474 invoked by uid 500); 28 Feb 2010 11:06:26 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 64467 invoked by uid 99); 28 Feb 2010 11:06:26 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Feb 2010 11:06:26 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Feb 2010 11:06:25 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id B34DB234C1F2 for ; Sun, 28 Feb 2010 11:06:05 +0000 (UTC) Message-ID: <1087613460.19361267355165719.JavaMail.jira@brutus.apache.org> Date: Sun, 28 Feb 2010 11:06:05 +0000 (UTC) From: "Shai Erera (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Updated: (LUCENE-2290) Remove unnecessary String concatenation in IndexWriter In-Reply-To: <731492906.19351267355045754.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2290: ------------------------------- Attachment: LUCENE--2290.patch Patch w/ the mentioned fixes. > Remove unnecessary String concatenation in IndexWriter > ------------------------------------------------------ > > Key: LUCENE-2290 > URL: https://issues.apache.org/jira/browse/LUCENE-2290 > Project: Lucene - Java > Issue Type: Improvement > Components: Index > Reporter: Shai Erera > Priority: Minor > Fix For: 3.1 > > Attachments: LUCENE--2290.patch > > > I've noticed a couple of places in IndexWriter where a boolean string is created by bool + "", or integer by int + "". There are some places (in setDiagonstics) where a string is concatenated with an empty String ... > The patch uses Boolean.toString and Integer.toString, as well as remove the unnecessary str + "". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org