lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: Modules
Date Fri, 26 Mar 2010 16:09:30 GMT
I think we should consolidate all query parsers as a module?  And all
queries (contrib/queries + oal/search/*Query)?

I don't think we should leave "basic X" inside core... I think there
should be one place to get the different Xs lucene offers (where X is
a query parser, queries, analyzers, etc.).  When you buy an engine it
doesn't come with basic windshield wipers or basic tires...

Ie, it shouldn't be expected that core would be usable on its own,
right?  It is today, but that's just because it bundles so much and
we've all gotten used to core being a bundle...

On tests... I wouldn't mind if core tests (but not core itself)
depended on modules.  I don't think that's bad... the tests will need
a query parser, queries, analyzers.  Making test-only variants (eg a
TestAnalyzer) is OK but I worry that this'd promote homogeneity in our
testing.  Ie now we have some degree of "realism" in our tests because
we use real analyzers, real query parser, real queries.

We could also do a fast cutover, allowing tests to depend on modules,
but then aim with time to remove that dependency...

Mike

On Fri, Mar 26, 2010 at 11:24 AM, Robert Muir <rcmuir@gmail.com> wrote:
> 2010/3/26 Shai Erera <serera@gmail.com>:
>> +1 for moving modules up one level.
>>
>> As for analyzers, I also prefer if lucene won't depend on modules even
>> if just for the tests. That way one who doesn't use any module can
>> check out lucene only. We can keep in lucene some basic analyzers
>> (Whitespace, Simple) as well as a best out of the box choice -
>> Standard for new users.
>>
>> Shai
>
> Shai, personally i am happy just to try to merge in the solr
> functionality with what we have in contrib, so it doesn't matter too
> much. But at the same time maybe we should reconsider this
> Whitespace/Simple/Standard case. I do think its a little wierd to have
> analyzers scattered all over the place... but two places instead of
> three is still an improvement.
>
> I would really love to see them all in one place though, for the
> users. I think that the elegance of our tests should be second to the
> users ease.
> Perhaps we could just have a fast and dirty TestAnalyzer so the core
> tests don't need to depend on analyzers instead???
>
> --
> Robert Muir
> rcmuir@gmail.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message