lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: Implementing new collectors
Date Tue, 23 Mar 2010 17:57:15 GMT
OK put it up!  Sounds good :)

Mike

On Tue, Mar 23, 2010 at 1:54 PM, Grant Ingersoll <gsingers@apache.org> wrote:
>
> On Mar 23, 2010, at 1:20 PM, Michael McCandless wrote:
>
>> You can implement just the "out of order" collector, since it subsumes
>> the in-order case, and all will work fine.
>>
>> However, if the collector can save CPU when docs are known to arrive
>> in-order (not all collectors can) it'd be good to make a separate
>> in-order one as well.
>
> Since the thing I'm working on is a Paging Collector and it extends TopDocsCollector,
and the logic looks more or less like that of the OutOfOrderTopScoreDocCollector, I think
we could likewise save a few if checks with an in order one.
>
> How about I put a patch up and then you can take a look?  My gut says it should be possible.
>
> -Grant
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message