lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: Turning IndexReader.isDeleted implementations to final
Date Wed, 03 Mar 2010 16:18:34 GMT
This is actually what I mean by [intentional] door shutting -- we want
to disallow extending our analyzers because it can easily lead to
sneaky problems, and, because it's so simple to make your own analyzer
that builds up the same chain.

Mike

On Wed, Mar 3, 2010 at 11:14 AM, Robert Muir <rcmuir@gmail.com> wrote:
> In the analyzers case, I don't think its really door-shutting. if someone
> extends an Analyzer, its likely to just result in problems from the
> tokenStream/reusableTokenStream mess.
>
> On Wed, Mar 3, 2010 at 11:10 AM, Grant Ingersoll <gsingers@apache.org>
> wrote:
>>
>> On Mar 1, 2010, at 2:51 AM, Michael McCandless wrote:
>>
>> > Yeah in the case of DirectoryReader/MultiReader, I'd like for them to
>> > be final, not for performance but for door-shutting (ie the same
>> > reason we make analyzers final).
>>
>> Door shutting often is not a good thing, especially in a project like
>> Lucene where many people extend in ways we can't dream of.
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>
>
>
> --
> Robert Muir
> rcmuir@gmail.com
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message