lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: Turning IndexReader.isDeleted implementations to final
Date Sun, 28 Feb 2010 17:05:17 GMT
Seems OK I think?

Mike

On Sun, Feb 28, 2010 at 12:37 AM, Shai Erera <serera@gmail.com> wrote:
> Hi
>
> Do you think it's worth to make some of the isDeleted method impls final,
> like in ReadOnlySegmentReader and (maybe) DirectoryReader? I'm thinking the
> classes that are perceived as final could benefit from that, since their
> impl could be inlined. Maybe just make these classes final entirely?
>
> Shai
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message