lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Muir <rcm...@gmail.com>
Subject Re: Contrib tests fail if core jar is not up to date
Date Thu, 18 Mar 2010 21:38:33 GMT
On Thu, Mar 18, 2010 at 5:33 PM, Shai Erera <serera@gmail.com> wrote:
> Hi
>
> I've noticed that sometimes, after I run test-core and test-contrib, and
> then change core code, test-contrib fail on NoSuchMethodError and stuff like
> that. I've noticed that core.jar exists under build, and I assumed it's used
> by test-contrib, and probably is not recreated after core code has changed.
>
> I verified it when looking in contrib-build.xml, which defines a property
> lucene.jar.present which is set to true if the jar is ... well, present.
> Which I believe is the reason for these failures. I've been thinking how to
> resolve that, and I can think of two ways:
>
> (1) have test-core always delete that file, but that has two issues:
> (1.1) It's redundant if the code hasn't changed.
> (1.2) It forces you to either jar-core or test-core before you test-contrib,
> if you want to make sure you run w/ the latest jar.
>
> or
>
> (2) have test-contrib always call jar-core, which will first delete the file
> and then re-create it by compiling first. Compiling should not do anything
> if the code hasn't changed. So the only waste would be to create the .jar,
> but I think that's quite fast?
>
> Does anyone, with more Ant skills than me, know of a better way to detect
> from test-contrib that core code has changed and only then rebuild the jar?
>
> Shai
>

In addition to what Shai mentioned, I wanted to say that there are
other oddities about how the contrib tests run in ant. For example,
I'm not sure why we create the junitfailed.flag files (I think it has
something to do with detecting top-level that a single contrib
failed).

I noticed this when working on
https://issues.apache.org/jira/browse/LUCENE-1709, as I guess we
should really fix it before doing that issue.

-- 
Robert Muir
rcmuir@gmail.com

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message