lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2215) paging collector
Date Wed, 24 Mar 2010 15:05:29 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849211#action_12849211
] 

Shai Erera commented on LUCENE-2215:
------------------------------------

Ohh I see. Missed that. So that can be folded into TSDC.create, or actually another create
method which in addition to numHits specifies a 'startFrom' w/ a ScoreDoc, and a similar one
for TFC.create. The only complication I see is that if we want to make it extremely efficient,
we'll need to double the number of Collector impls for TSDC and TFC (the internal instances
that are created) ...

Then ... I think ... TDC can have just one topDocs() indeed.

But the idea of doubling the number of collector impls worries me. Especially for cases where
even for paging, you won't use the Paging thing because you simply don't maintain any state
on the server. I wonder if for those apps, who do maintain the state, and I imagine there
aren't lots of them, having a PagingCollector which either wraps TSDC, or is the one you provided
in the patch (but does not extend TDC) would be better? It won't unnecessarily over-complicate
the code of TSDC and TFC (which will have 12 impls) and give you sort of what you need - if
you maintain state, then you know that's the second page the user requested, so using a PagingCollector
specifically doesn't sound that bad to me?

> paging collector
> ----------------
>
>                 Key: LUCENE-2215
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2215
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Search
>    Affects Versions: 2.4, 3.0
>            Reporter: Adam Heinz
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: IterablePaging.java, LUCENE-2215.patch, PagingCollector.java, TestingPagingCollector.java
>
>
> http://issues.apache.org/jira/browse/LUCENE-2127?focusedCommentId=12796898&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12796898
> Somebody assign this to Aaron McCurry and we'll see if we can get enough votes on this
issue to convince him to upload his patch.  :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message