lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] Commented: (LUCENE-2318) Add System.getProperty("tempDir") as final static to LuceneTestCase(J4)
Date Sun, 14 Mar 2010 07:19:27 GMT


Shai Erera commented on LUCENE-2318:

Uwe, can you default to "" instead? "." is not properly defined. It will create
indexes in the current directory where the tests run from, which is different if I run "ant
test" from <root>, <root>/contrib and <root>/benchmark ...

Or, we can tweak common-build.xml to fallback to <root>/test. In fact, looking in common-build.xml,
I already see tempDir defaults to {build.dir}/test. Look at lines 448 (where it is set), 417
where it is used and 418 where is set to that value.

Maybe we need to change the definition of build.dir from location="build" to location="{common.dir}/build"
so that it always references <root>/build.

And if run from eclipse, default TEMP_DIR constant to ""?

> Add System.getProperty("tempDir") as final static to LuceneTestCase(J4)
> -----------------------------------------------------------------------
>                 Key: LUCENE-2318
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Test
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.1
> Almost every test calls System.getProperty("tempDir") and some of them check the return
value for null. In other cases the test simply fails from within eclipse.
> We should add this to LuceneTestCase(J4) as a static final constant. For enabling tests
run in eclipse, we can add a fallback to ".", if the Sysprop is not defined.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message