lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] Commented: (LUCENE-2015) ASCIIFoldingFilter: expose folding logic + small improvements to ISOLatin1AccentFilter
Date Wed, 10 Mar 2010 15:31:27 GMT


Robert Muir commented on LUCENE-2015:

Thanks Cédrik, I like your latest change.

My primary reasoning for minimizing the API is because each exposed 
method has some cost to us (backwards compatibility).

I think if someone wants to fold a String they can still work with this API,
e.g. use a char[1] container, and not even bother if charAt() < 0x7F, etc.

In general I guess i am less concerned about this as the Lucene API 
doesn't use String.

I will commit in a day or two if no one objects.

> ASCIIFoldingFilter: expose folding logic + small improvements to ISOLatin1AccentFilter
> --------------------------------------------------------------------------------------
>                 Key: LUCENE-2015
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Cédrik LIME
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 3.1
>         Attachments: ASCIIFoldingFilter-no_formatting.patch, ASCIIFoldingFilter-no_formatting.patch,
Filters.patch, ISOLatin1AccentFilter.patch, LUCENE-2015.patch, LUCENE-2015.patch
> This patch adds a couple of non-ascii chars to ISOLatin1AccentFilter (namely: left &
right single quotation marks, en dash, em dash) which we very frequently encounter in our
projects. I know that this class is now deprecated; this improvement is for legacy code that
hasn't migrated yet.
> It also enables easy access to the ascii folding technique use in ASCIIFoldingFilter
for potential re-use in non-Lucene-related code.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message