lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2323) reorganize contrib modules
Date Thu, 18 Mar 2010 01:10:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846707#action_12846707
] 

Hoss Man commented on LUCENE-2323:
----------------------------------

bq. Perhaps I want to refactor some code among our 7 queryparsers or 2 highlighters or whatever,
the only way I can do this is to shove stuff (shared code) into core, I think this is bad.

agreed ... IIRC the idea in this discussion was the have a lot more smaller "modules", with
a lot better defined/advertised dependencies, so that module X,Y,Z might all depend on modules
A, and B (which had the common refactored code you speak of) and the "core" module is special
in that it must never depend on anything else.

Like i said: I personally don't have a very strong opinion about this, i think people who
are really concerned about jar sizes can compile their own after pruning the classes they
don't care about -- but it's definitely harder when those classes are all in one atomic source
tree where you might not notice that someone refactored a common dependency that wasn't there
before.


> reorganize contrib modules
> --------------------------
>
>                 Key: LUCENE-2323
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2323
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>            Reporter: Robert Muir
>
> it would be nice to reorganize contrib modules, so that they are bundled together by
functionality.
> For example:
> * the wikipedia contrib is a tokenizer, i think really belongs in contrib/analyzers
> * there are two highlighters, i think could be one highlighters package.
> * there are many queryparsers and queries in different places in contrib

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message