lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Smith (JIRA)" <j...@apache.org>
Subject [jira] Created: (LUCENE-2345) Make it possible to subclass SegmentReader
Date Wed, 24 Mar 2010 18:41:27 GMT
Make it possible to subclass SegmentReader
------------------------------------------

                 Key: LUCENE-2345
                 URL: https://issues.apache.org/jira/browse/LUCENE-2345
             Project: Lucene - Java
          Issue Type: Wish
          Components: Index
            Reporter: Tim Smith
             Fix For: 3.1


I would like the ability to subclass SegmentReader for numerous reasons:
* to capture initialization/close events
* attach custom objects to an instance of a segment reader (caches, statistics, so on and
so forth)
* override methods on segment reader as needed

currently this isn't really possible

I propose adding a SegmentReaderFactory that would allow creating custom subclasses of SegmentReader

default implementation would be something like:
{code}
public class SegmentReaderFactory {
  public SegmentReader get(boolean readOnly) {
    return readOnly ? new ReadOnlySegmentReader() : new SegmentReader();
  }

  public SegmentReader reopen(SegmentReader reader, boolean readOnly) {
    return newSegmentReader(readOnly);
  }
}
{code}

It would then be made possible to pass a SegmentReaderFactory to IndexWriter (for pooled readers)
as well as to SegmentReader.get() (DirectoryReader.open, etc)

I could prepare a patch if others think this has merit

Obviously, this API would be "experimental/advanced/will change in future"




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message