lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2339) Allow Directory.copy() to accept a collection of file names to be copied
Date Wed, 24 Mar 2010 20:19:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849404#action_12849404
] 

Shai Erera commented on LUCENE-2339:
------------------------------------

Do we want to suppress only IOExceptions? What about any RuntimeExceptions - upon hitting
any of them the code will fly away? Not saying it's a bad thing, but pointing it out.

Other than that, the patch looks good. closeSafely is not exactly what I had in mind about
closeNoException because it forces you to catch the IOE if you don't declare you throw it,
or you need to move on, discarding it. But I guess this is a matter for another issue. 

> Allow Directory.copy() to accept a collection of file names to be copied
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-2339
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2339
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Earwin Burrfoot
>            Assignee: Michael McCandless
>         Attachments: LUCENE-2339.patch, LUCENE-2339.patch, LUCENE-2339.patch, LUCENE-2339.patch,
LUCENE-2339.patch
>
>
> Par example, I want to copy files pertaining to a certain commit, and not everything
there is in a Directory.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message