lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] Commented: (LUCENE-2318) Add System.getProperty("tempDir") as final static to LuceneTestCase(J4)
Date Sun, 14 Mar 2010 08:43:27 GMT


Uwe Schindler commented on LUCENE-2318:

bq. Uwe, can you default to "" instead?

The problem are only test runs outside ANT. If you run the tests from ANT there is never a
problem, they use ${build.dir}/test, which is perfectly defined. But the tempDir system property
is not set when running the tests from eclipse. So Your suggestion to fallback to
is a good idea, maybe with "/lucene-test" appended.

bq. Maybe we need to change the definition of build.dir from location="build" to location="{common.dir}/build"
so that it always references <root>/build.

This would break contrib. Its defined correctly at the moment, as ANT guarantees that "."
or the current dir defaults to the `dirname build.xml`.

bq. Or, we can tweak common-build.xml to fallback to <root>/test.

common-build never needs a fallback, as its always defined. and <root>/test is exactly
what we do not want to have as it will not be cleaned up on "ant clean"

> Add System.getProperty("tempDir") as final static to LuceneTestCase(J4)
> -----------------------------------------------------------------------
>                 Key: LUCENE-2318
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Test
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.1
> Almost every test calls System.getProperty("tempDir") and some of them check the return
value for null. In other cases the test simply fails from within eclipse.
> We should add this to LuceneTestCase(J4) as a static final constant. For enabling tests
run in eclipse, we can add a fallback to ".", if the Sysprop is not defined.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message