lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grant Ingersoll (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2215) paging collector
Date Wed, 24 Mar 2010 14:06:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849193#action_12849193
] 

Grant Ingersoll commented on LUCENE-2215:
-----------------------------------------

{quote}
I must admit I don't like throwing UOE. I imagine the naive user calling one of these and
hit w/ UOE out of nowhere really . Perhaps it's a sign PagingCollector should not be a sub-class
of TopDocsCollector? It does not benefit from it in any way because it overrides all the main
methods, impls them or throws UOE for those it doesn't like. So perhaps it should just be
a TopScorePagingCollector which copies some of the functionality of TSDC, but is not a TDC
itself. It will have a topDocs() method, and only it (b/c I agree the rest don't make any
sense).
{quote}

I agree, not a huge fan of it either, but it is bad form to call it when using this collector
and I'd rather people learn that up front.  Like I said in the last comment, I think we'd
be better off trying to integrate this in to a lower level and not even having a "special"
collector.  If we just added a create option that took in the necessary info, then we could
just mod the existing collectors, possibly.  Then those two topDocs methods could just be
deprecated/removed.

> paging collector
> ----------------
>
>                 Key: LUCENE-2215
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2215
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Search
>    Affects Versions: 2.4, 3.0
>            Reporter: Adam Heinz
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: IterablePaging.java, LUCENE-2215.patch, PagingCollector.java, TestingPagingCollector.java
>
>
> http://issues.apache.org/jira/browse/LUCENE-2127?focusedCommentId=12796898&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12796898
> Somebody assign this to Aaron McCurry and we'll see if we can get enough votes on this
issue to convince him to upload his patch.  :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message