lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2277) QueryNodeImpl throws ConcurrentModificationException on add(List<QueryNode>)
Date Sat, 06 Mar 2010 22:48:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842332#action_12842332
] 

Simon Willnauer commented on LUCENE-2277:
-----------------------------------------

Robert, should the changes text rather say something about the argument that was completely
ignored. This was simply a bug due to ignoring the argument but calling a similar named method.
Could be a bit picky but I thought I should mention it.

Simon

> QueryNodeImpl throws ConcurrentModificationException on add(List<QueryNode>)
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-2277
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2277
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/*
>    Affects Versions: 3.0
>         Environment: all
>            Reporter: Frank Wesemann
>            Assignee: Robert Muir
>            Priority: Critical
>             Fix For: 3.1
>
>         Attachments: addChildren.patch, LUCENE-2277.patch
>
>
> on adding a List of children to a QueryNodeImplemention a ConcurrentModificationException
is thrown.
> This is due to the fact that QueryNodeImpl instead of iteration over the supplied list,
iterates over its internal clauses List.
> Patch:
> Index: QueryNodeImpl.java
> ===================================================================
> --- QueryNodeImpl.java    (revision 911642)
> +++ QueryNodeImpl.java    (working copy)
> @@ -74,7 +74,7 @@
>            .getLocalizedMessage(QueryParserMessages.NODE_ACTION_NOT_SUPPORTED));
>      }
>  
> -    for (QueryNode child : getChildren()) {
> +    for (QueryNode child : children) {
>        add(child);
>      }
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message