lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grant Ingersoll (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2215) paging collector
Date Fri, 26 Mar 2010 00:26:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849961#action_12849961
] 

Grant Ingersoll commented on LUCENE-2215:
-----------------------------------------

Yeah, but one could make the argument, Mike, that the existing "optimizations" are useless
for the most common case, since I think it's safe to say most applications implement paging.
 Of course, that being said, most users don't page all that deeply.  Also, for something like
Solr that prefetches the top 50 it might not be good, either.  Still, in my mind it is one
additional boolean check, as in:
{code}
if ( (current stuff) || (pagingInfoPresent == true && paging check) )
...
{code}

pagingInfoPresent can be determined at construction time and that whole clause would be short
circuited very quickly.

That being said, delegation could be done at construction time, too and more cleanly separates
things.  I'll try to put up my version tomorrow.

> paging collector
> ----------------
>
>                 Key: LUCENE-2215
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2215
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Search
>    Affects Versions: 2.4, 3.0
>            Reporter: Adam Heinz
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: IterablePaging.java, LUCENE-2215.patch, PagingCollector.java, TestingPagingCollector.java
>
>
> http://issues.apache.org/jira/browse/LUCENE-2127?focusedCommentId=12796898&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12796898
> Somebody assign this to Aaron McCurry and we'll see if we can get enough votes on this
issue to convince him to upload his patch.  :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message