lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] Commented: (LUCENE-2309) Fully decouple IndexWriter from analyzers
Date Thu, 11 Mar 2010 18:14:27 GMT


Shai Erera commented on LUCENE-2309:

Would this mean that after that we can move all of core Analyzers to contrib/analyzers, making
one step towards getting them completely out of Lucene and into their own Apache project?

That way, we can keep in core only the AttributeSource and accompanying classes, and really
allow people to pass AttributeSource which is not even an Analyzer (like you said). We can
move the specific Analyzer tests to contrib/analyzers as well. The other tests in core, who
don't care about analysis, can use a src/test specific AttributeSource, like TestAttributeSourceImpl

I'm thinking - it's ok for contrib to depend on core but not the other way around. It will
however take out of core a useful feature for new users which allows fast bootstrap. That
won't be the case when analyzers move out of Lucene entirely, but while they are in Lucene,
we'll force everyone to download contrib/analyzers as well. So maybe we keep in core only
Standard, or maybe even something simpler, again, for easy bootstrapping (like Whitespace
+ lowercase).

This is just a thought.

> Fully decouple IndexWriter from analyzers
> -----------------------------------------
>                 Key: LUCENE-2309
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael McCandless
> IndexWriter only needs an AttributeSource to do indexing.
> Yet, today, it interacts with Field instances, holds a private
> analyzers, invokes analyzer.reusableTokenStream, has to deal with a
> wide variety (it's not analyzed; it is analyzed but it's a Reader,
> String; it's pre-analyzed).
> I'd like to have IW only interact with attr sources that already
> arrived with the fields.  This would be a powerful decoupling -- it
> means others are free to make their own attr sources.
> They need not even use any of Lucene's analysis impls; eg they can
> integrate to other things like [OpenPipeline|].
> Or make something completely custom.
> LUCENE-2302 is already a big step towards this: it makes IW agnostic
> about which attr is "the term", and only requires that it provide a
> BytesRef (for flex).
> Then I think LUCENE-2308 would get us most of the remaining way -- ie, if the
> FieldType knows the analyzer to use, then we could simply create a
> getAttrSource() method (say) on it and move all the logic IW has today
> onto there.  (We'd still need existing IW code for back-compat).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message