lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1814) Some Lucene tests try and use a Junit Assert in new threads
Date Sun, 21 Mar 2010 15:22:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847934#action_12847934
] 

Uwe Schindler commented on LUCENE-1814:
---------------------------------------

bq. so unless a failure is caused later from the thread termination, the Asserts are invalid

This is one small problem: The exceptions from external threads are collected on tearDown().
So the assert message is only printed and the test failing in tearDown(). So this does not
prevent failures in the main thread before the failures in other thread's assert statements
are detected. But one is sure: The failures are detected and the test is failing.

> Some Lucene tests try and use a Junit Assert in new threads
> -----------------------------------------------------------
>
>                 Key: LUCENE-1814
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1814
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Priority: Minor
>
> There are a few cases in Lucene tests where JUnit Asserts are used inside a new threads
run method - this won't work because Junit throws an exception when a call to Assert fails
- that will kill the thread, but the exception will not propagate to JUnit - so unless a failure
is caused later from the thread termination, the Asserts are invalid.
> TestThreadSafe
> TestStressIndexing2
> TestStringIntern

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message