lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2215) paging collector
Date Fri, 26 Mar 2010 04:23:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850002#action_12850002
] 

Shai Erera commented on LUCENE-2215:
------------------------------------

bq. since I think it's safe to say most applications implement paging

Let's be careful about the semantics here Grant. Most if not all applications implement paging
indeed, but I believe only FEW actually store user contexts between searches. PagingCollector
relies on the application to store the lowest ranking doc that was returned previously, which
means storing context between user's searches.

I agree w/ Mike's statement about 99.9% of the searches would never run that code, which is
why I've proposed a delegation/wrapper approach from the beginning. I also think that we should
make some allowances here and there, for the non-common case, and introduce better software
design than specialized code. A Collector filter approach for some rare (or even less common)
cases seems very reasonable to me.

Also, I think that if we add to TSDC a create method which takes into account the previously
scored lowest doc, it will confuse people. Now they will need to think "where do I get this
low score from?" - but perhaps after I see the code, it wouldn't be such a bad thing ....
just have a feeling TSDC and TFC should be left on their own, and extreme paging stuff should
either be its own specialized collector, or a wrapper.

> paging collector
> ----------------
>
>                 Key: LUCENE-2215
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2215
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Search
>    Affects Versions: 2.4, 3.0
>            Reporter: Adam Heinz
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: IterablePaging.java, LUCENE-2215.patch, PagingCollector.java, TestingPagingCollector.java
>
>
> http://issues.apache.org/jira/browse/LUCENE-2127?focusedCommentId=12796898&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12796898
> Somebody assign this to Aaron McCurry and we'll see if we can get enough votes on this
issue to convince him to upload his patch.  :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message