lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2289) Calls to SegmentInfos.message should be wrapped w/ infoStream != null checks
Date Sun, 28 Feb 2010 16:45:06 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839445#action_12839445
] 

Shai Erera commented on LUCENE-2289:
------------------------------------

Are you talking about this:  if (exc != null && infoStream != null) {

It used to be
{code}
if (exc != null) {
  message();
}
{code}

And I changed it to
{code}
if (exc != null && infoStream != null) {
  message();
}
{code}

Or is it something else?

Anyway according to the patch it's on rev. 917047?

> Calls to SegmentInfos.message should be wrapped w/ infoStream != null checks
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-2289
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2289
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>            Assignee: Michael McCandless
>             Fix For: 3.1
>
>         Attachments: LUCENE--2289.patch
>
>
> To avoid the expensive message creation (which involves the '+' operator on strings,
calls to message should be wrapped w/ infoStream != null check, rather than inside message().
I'll attach a patch which does that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message