lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grant Ingersoll (JIRA)" <>
Subject [jira] Updated: (LUCENE-2215) paging collector
Date Tue, 23 Mar 2010 20:37:27 GMT


Grant Ingersoll updated LUCENE-2215:

    Attachment: LUCENE-2215.patch

Here's an update of Aaron's work with the following changes:

1. Added real unit tests
2. Made topDocs() non final in order to override in PagingCollector to handle the case where
the some edge cases with larger PQ size than total hits.  Overrode the other topDocs(...)
methods to throw UnsupportedOperation as they aren't needed for a Paging Collector
3. Pass in num already seen so that PQ operations can be calculated correctly.  Not sure if
we really need, but otherwise it puts the burden on the user to make sure the PQ is sized
properly, I think, which may not be such a bad burden
4. Renamed IterablePaging to be PagingIterable.  Not a huge fan of that name either, but couldn't
think of anything better
5. Collapsed the if/else clauses in the collect method into a single if clause.

Left to do:
1. benchmark.  Is it really better?
2. Not entirely certain on the PagingIterable API stuff yet.  Looks useful.
3. Should we have an InOrder Collector as well?  Seems like we might be able to save a few
operations per doc.

> paging collector
> ----------------
>                 Key: LUCENE-2215
>                 URL:
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Search
>    Affects Versions: 2.4, 3.0
>            Reporter: Adam Heinz
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments:, LUCENE-2215.patch,,
> Somebody assign this to Aaron McCurry and we'll see if we can get enough votes on this
issue to convince him to upload his patch.  :)

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message