lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <>
Subject [jira] Updated: (LUCENE-2310) Reduce Fieldable, AbstractField and Field complexity
Date Sat, 13 Mar 2010 19:12:27 GMT


Chris Male updated LUCENE-2310:

    Attachment: LUCENE-2310-Deprecate-AbstractField.patch

Addressed the issues raised by Uwe about the TokenStream in NumericField.  NumericField now
throws a UOE on setTokenStream.  Since it  also extends Field which has its own TokenStream
field, NumericField now uses the field from TokenStream rather than its own.

The more and more this is discussed the clearer it is that Field should be the base class
of the Field hierarchy, and not AbstractField or Fieldable.  The issue of having all the setters
and configurations will be addressed in LUENE-2308 when we move them all to FieldType.  Field
will become a simple tuple consisting of at least a value and type, and possibly a TokenStream.

NumericField and LazyField are customisations of Field controlling certain aspects of the
tuple.  For NumericField that is the TokenStream and setting the value.  For LazyField that
is the value.

> Reduce Fieldable, AbstractField and Field complexity
> ----------------------------------------------------
>                 Key: LUCENE-2310
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: Index
>            Reporter: Chris Male
>         Attachments: LUCENE-2310-Deprecate-AbstractField.patch, LUCENE-2310-Deprecate-AbstractField.patch
> In order to move field type like functionality into its own class, we really need to
try to tackle the hierarchy of Fieldable, AbstractField and Field.  Currently AbstractField
depends on Field, and does not provide much more functionality that storing fields, most of
which are being moved over to FieldType.  Therefore it seems ideal to try to deprecate AbstractField
(and possible Fieldable), moving much of the functionality into Field and FieldType.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message