lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grant Ingersoll (JIRA)" <>
Subject [jira] Commented: (LUCENE-2343) Add support for benchmarking Collectors
Date Wed, 24 Mar 2010 20:03:27 GMT


Grant Ingersoll commented on LUCENE-2343:

bq. can be written as Class.forName(clnName).asSubclass(Collector.class).newInstance();


bq. Also, and it's a style issue, can you remove the '== true/false' from ifs?

No.  :-).  Feel free to leave them out, but I prefer it to be explicit.  See my rant at:

bq. I'd change if (clnName.equals("") == false) to if (clnName.length() > 0).


bq. Why does benchmark/build.xml now relies on the compiled classes/test (of core)?

Hmm, guess I didn't see that English got moved from test to core.

> Add support for benchmarking Collectors
> ---------------------------------------
>                 Key: LUCENE-2343
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LUCENE-2343.patch
> As the title says.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message