lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grant Ingersoll (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2343) Add support for benchmarking Collectors
Date Wed, 24 Mar 2010 20:03:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849390#action_12849390
] 

Grant Ingersoll commented on LUCENE-2343:
-----------------------------------------

bq. can be written as Class.forName(clnName).asSubclass(Collector.class).newInstance();

OK

bq. Also, and it's a style issue, can you remove the '== true/false' from ifs?

No.  :-).  Feel free to leave them out, but I prefer it to be explicit.  See my rant at: http://www.lucidimagination.com/search/document/476a10c1c687971d/randomseedgenerator#684ed7253617ea71

bq. I'd change if (clnName.equals("") == false) to if (clnName.length() > 0).

Sure.

bq. Why does benchmark/build.xml now relies on the compiled classes/test (of core)?

Hmm, guess I didn't see that English got moved from test to core.

> Add support for benchmarking Collectors
> ---------------------------------------
>
>                 Key: LUCENE-2343
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2343
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LUCENE-2343.patch
>
>
> As the title says.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message