lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-2303) Remove code duplication from Token class, just extend TermAttributeImpl
Date Mon, 08 Mar 2010 08:13:27 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler updated LUCENE-2303:
----------------------------------

    Attachment: LUCENE-2303.patch

Small improvements to the patch, removed an inconsistency in type's null check (added null
check in hashCode, too, as type may be null). Also changed this in TypeAttributeImpl.

Will commit this soon to trunk and merge up to head in flex.

> Remove code duplication from Token class, just extend TermAttributeImpl
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-2303
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2303
>             Project: Lucene - Java
>          Issue Type: Sub-task
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: Flex Branch, 3.1
>
>         Attachments: LUCENE-2303.patch, LUCENE-2303.patch, LUCENE-2303.patch
>
>
> This issue removes the code duplication from Token, as it shares the whole char[] buffer
handling code with TermAttributeImpl. This issue removes this duplication by just extending
TermAttributeImpl.
> When the parent issue LUCENE-2302 will extend TermAttribute to support CharSequence and
Appendable and also the new BytesRefAttribute gets added, Token will automatically provide
this too, so no further code duplication.
> This code should also be committed to trunk, as it has nothing to do with flex.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message