Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Message-ID: <984460074.521261267092088083.JavaMail.jira@brutus.apache.org>
Date: Thu, 25 Feb 2010 10:01:28 +0000 (UTC)
From: "Uwe Schindler (JIRA)" <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Issue Comment Edited: (LUCENE-2285) Code cleanup from all
 sorts of (trivial) warnings
In-Reply-To: <441548908.516151267072227868.JavaMail.jira@brutus.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838271#action_12838271 ] 

Uwe Schindler edited comment on LUCENE-2285 at 2/25/10 10:00 AM:
-----------------------------------------------------------------

bq. About the generics - any reason why not have a space after commas inside generics?

See the mailing list. And it is done like that everywhere in current luecen's source tree. And you have no problem, just use the codestyle xml file for the project and you are done.

[http://www.lucidimagination.com/search/document/62fe00098351dbe3/whitespace_inside_generics_parameters]

      was (Author: thetaphi):
    See the mailing list. And it is done like that everywhere in current luecen's source tree. And you have no problem, just use the codestyle xml file for the project and you are done.
  
> Code cleanup from all sorts of (trivial) warnings
> -------------------------------------------------
>
>                 Key: LUCENE-2285
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2285
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Shai Erera
>            Priority: Minor
>             Fix For: 3.1
>
>
> I would like to do some code cleanup and remove all sorts of trivial warnings, like unnecessary casts, problems w/ javadocs, unused variables, redundant null checks, unnecessary semicolon etc. These are all very trivial and should not pose any problem.
> I'll create another issue for getting rid of deprecated code usage, like LuceneTestCase and all sorts of deprecated constructors. That's also trivial because it only affects Lucene code, but it's a different type of change.
> Another issue I'd like to create is about introducing more generics in the code, where it's missing today - not changing existing API. There are many places in the code like that.
> So, with you permission, I'll start with the trivial ones first, and then move on to the others.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org