Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 35814 invoked from network); 23 Feb 2010 13:24:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Feb 2010 13:24:46 -0000 Received: (qmail 11831 invoked by uid 500); 23 Feb 2010 13:24:45 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 11774 invoked by uid 500); 23 Feb 2010 13:24:45 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 11766 invoked by uid 99); 23 Feb 2010 13:24:45 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Feb 2010 13:24:45 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of serera@gmail.com designates 74.125.78.24 as permitted sender) Received: from [74.125.78.24] (HELO ey-out-2122.google.com) (74.125.78.24) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Feb 2010 13:24:38 +0000 Received: by ey-out-2122.google.com with SMTP id d26so863824eyd.3 for ; Tue, 23 Feb 2010 05:24:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=pKzny0s1um98+rFYWLeTF8OxOnhLo4KCGhAGAnzZHVg=; b=T+ABz5avzkHfU5U8X42iwR18z/sA8HR78KBq99+5GN4U3j02EG+dKWSC+T84ikzqYt Z6hXCKyNZnrmA2xhDSg/ESEGaYtcgoWec5O3ElIlyEvAdPYTfo1KvK7UlvHC4aevD+kx o8vLD+ZScI1QGvtS6X18OqhtRG0EODfbnPivk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=bepWqMd5ftzZmSRRtU2f/XXOradcM7BE39Ap+ABApt0kRMKQFHaT3+buG9CQ+4NU4+ +qQ5CxrXk1wAgw3LZAQID0lmvRvvOAycLFb4bn5ujXdX3yTnPimVYQfo4kNikAGholkZ HO6lu2c/fd5IC3gyPUJUEPQVaUk4NTRQRmtEM= MIME-Version: 1.0 Received: by 10.213.1.147 with SMTP id 19mr517915ebf.57.1266931457190; Tue, 23 Feb 2010 05:24:17 -0800 (PST) In-Reply-To: <9ac0c6aa1002230511o29a50e42m7a0bf5644946f8f2@mail.gmail.com> References: <786fde51002230355u757767ccy4f1de06d8c28d7aa@mail.gmail.com> <9ac0c6aa1002230511o29a50e42m7a0bf5644946f8f2@mail.gmail.com> Date: Tue, 23 Feb 2010 15:24:17 +0200 Message-ID: <786fde51002230524x1dcafeebge9988aa4c1e9b65c@mail.gmail.com> Subject: Re: Add IndexWriter.doBeforeFlush() From: Shai Erera To: java-dev@lucene.apache.org Content-Type: multipart/alternative; boundary=000e0cdf979e75ea3804804477ea --000e0cdf979e75ea3804804477ea Content-Type: text/plain; charset=ISO-8859-1 on it ! Shai On Tue, Feb 23, 2010 at 3:11 PM, Michael McCandless < lucene@mikemccandless.com> wrote: > +1 to both adding doAfterFlush and making the two methods protected. > Patch? > > Mike > > On Tue, Feb 23, 2010 at 6:55 AM, Shai Erera wrote: > > Hi, > > > > Can we add to IW a doBeforeFlush(), similar to doAfterFlush(), which will > > get called before flush actually happens (i.e., at the beginning of > > flush())? IW.flush() is final and so I cannot override it, but I do take > > advantage of doAfterFlush(). I need though a way to execute some code > before > > the flush begins ... > > > > On that matter, can we turn doAfterFlush to protected? It's designed to > be > > an extension point, yet still package private. Since it does not include > any > > logic (as well as doBeforeFlush shouldn't), and all we'll need to > guarantee > > is that we'll call both before and after flush, I think it'll make sense > to > > make these two 'public' in nature, i.e. protected visibility. > > > > What do you think? > > > > Shai > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org > For additional commands, e-mail: java-dev-help@lucene.apache.org > > --000e0cdf979e75ea3804804477ea Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
on it !

Shai

On T= ue, Feb 23, 2010 at 3:11 PM, Michael McCandless <lucene@mikemccandless.com> wrote:
+1 to both adding= doAfterFlush and making the two methods protected. =A0Patch?

Mike

On Tue, Feb 23, 2010 at 6:55 AM, Shai Erera <serera@gmail.com> wrote:
> Hi,
>
> Can we add to IW a doBeforeFlush(), similar to doAfterFlush(), which w= ill
> get called before flush actually happens (i.e., at the beginning of > flush())? IW.flush() is final and so I cannot override it, but I do ta= ke
> advantage of doAfterFlush(). I need though a way to execute some code = before
> the flush begins ...
>
> On that matter, can we turn doAfterFlush to protected? It's design= ed to be
> an extension point, yet still package private. Since it does not inclu= de any
> logic (as well as doBeforeFlush shouldn't), and all we'll need= to guarantee
> is that we'll call both before and after flush, I think it'll = make sense to
> make these two 'public' in nature, i.e. protected visibility.<= br> >
> What do you think?
>
> Shai
>

-----------------------------= ----------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


--000e0cdf979e75ea3804804477ea--