Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: pass (athena.apache.org: domain of serera@gmail.com designates
 74.125.78.26 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=F67UyhRrGeBhAWFtCH8mKDWDq7enpaUnv35BZBRb4NicJ73CE41BMB3/tLqFnJ52Wg
         axCPH6giWo/pfro3hrmGb+R6y7KYU0PgeLmQrJHUD6tBQphOBhy43123jA5YkydL8ycN
         uK9tRWsicUF1nk/b/Fp7z/d1Q87NhKng/VSC0=
MIME-Version: 1.0
In-Reply-To: <9ac0c6aa1002230352i614fdb4bxae00a0bd118934cc@mail.gmail.com>
References: <786fde51002222242y7504f736n440b92bdb9c60138@mail.gmail.com>
	 <9ac0c6aa1002230316x48cc41f0gd8748e05a93466d8@mail.gmail.com>
	 <786fde51002230322gcd8bb8fpeef81e06817a6647@mail.gmail.com>
	 <9ac0c6aa1002230331k38a8a748p1b5180ec9100efe2@mail.gmail.com>
	 <786fde51002230346v59c4bbdckbd60561a4a0182fc@mail.gmail.com>
	 <9ac0c6aa1002230352i614fdb4bxae00a0bd118934cc@mail.gmail.com>
Date: Tue, 23 Feb 2010 13:56:15 +0200
Message-ID: <786fde51002230356l3355186k7195302b14be8e5a@mail.gmail.com>
Subject: Re: IndexFileNames
From: Shai Erera <serera@gmail.com>
To: java-dev@lucene.apache.org
Content-Type: multipart/alternative; boundary=000e0cdf979eab4e520480433cf9

--000e0cdf979eab4e520480433cf9
Content-Type: text/plain; charset=ISO-8859-1

ok great !

I'll create an issue and work out a patch.

Shai

On Tue, Feb 23, 2010 at 1:52 PM, Michael McCandless <
lucene@mikemccandless.com> wrote:

> On Tue, Feb 23, 2010 at 6:46 AM, Shai Erera <serera@gmail.com> wrote:
> > I don't think performance is the issue here, but rather correctness.
> Someone
> > cannot just ask filename.endsWith(DELETION_EXT) as files like "file1del"
> > would match as well. So whenever you make such check, you need to add
> ".".
> > Again, not performance, but correctness.
>
> I see.  To address this we could create a new method on IFN
> (matchesExtension?), so one should never use string ops on IFN's
> constants?
>
> > If we make it public, then we can document that clearly. I don't mind if
> we
> > stay w/o the ".". I just thought that we can correct it, and gain few
> ticks
> > of performance as a side effect. But I don't want to argue about it :).
> >
> > So do you agree to change it to public? I can do that and also make sure
> > Lucene's code always calls segmentFileName ...
>
> OK let's leave the extensions as they are (no dots), make it public,
> and fix Lucene to always use IFNs methods when working with index file
> names?  Thanks!
>
> Mike
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>

--000e0cdf979eab4e520480433cf9
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">ok great !<br><br>I&#39;ll create an issue and work out a =
patch.<br><br>Shai<br><br><div class=3D"gmail_quote">On Tue, Feb 23, 2010 a=
t 1:52 PM, Michael McCandless <span dir=3D"ltr">&lt;<a href=3D"mailto:lucen=
e@mikemccandless.com">lucene@mikemccandless.com</a>&gt;</span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, =
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class=3D"im"=
>On Tue, Feb 23, 2010 at 6:46 AM, Shai Erera &lt;<a href=3D"mailto:serera@g=
mail.com">serera@gmail.com</a>&gt; wrote:<br>

&gt; I don&#39;t think performance is the issue here, but rather correctnes=
s. Someone<br>
&gt; cannot just ask filename.endsWith(DELETION_EXT) as files like &quot;fi=
le1del&quot;<br>
&gt; would match as well. So whenever you make such check, you need to add =
&quot;.&quot;.<br>
&gt; Again, not performance, but correctness.<br>
<br>
</div>I see. =A0To address this we could create a new method on IFN<br>
(matchesExtension?), so one should never use string ops on IFN&#39;s<br>
constants?<br>
<div class=3D"im"><br>
&gt; If we make it public, then we can document that clearly. I don&#39;t m=
ind if we<br>
&gt; stay w/o the &quot;.&quot;. I just thought that we can correct it, and=
 gain few ticks<br>
&gt; of performance as a side effect. But I don&#39;t want to argue about i=
t :).<br>
&gt;<br>
&gt; So do you agree to change it to public? I can do that and also make su=
re<br>
&gt; Lucene&#39;s code always calls segmentFileName ...<br>
<br>
</div>OK let&#39;s leave the extensions as they are (no dots), make it publ=
ic,<br>
and fix Lucene to always use IFNs methods when working with index file<br>
names? =A0Thanks!<br>
<br>
Mike<br>
<div><div></div><div class=3D"h5"><br>
---------------------------------------------------------------------<br>
To unsubscribe, e-mail: <a href=3D"mailto:java-dev-unsubscribe@lucene.apach=
e.org">java-dev-unsubscribe@lucene.apache.org</a><br>
For additional commands, e-mail: <a href=3D"mailto:java-dev-help@lucene.apa=
che.org">java-dev-help@lucene.apache.org</a><br>
<br>
</div></div></blockquote></div><br></div>

--000e0cdf979eab4e520480433cf9--