Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: pass (athena.apache.org: domain of serera@gmail.com designates
 209.85.219.218 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=wTrc7etpOADA/Gnl33wg++oxf4d/Bhz7GSLxBvAvnBXRXUhkIeMHh1n0TjlMI5NJ6P
         1QpBzLlX/Pw0xl93qQuBN/k78LlZ6z2QTM1QVrrY59gEH5wLp6MxXhTxmbh8AfZ2k9PV
         fjukTMASSG7EoUJNkhZr+QyUXd6nVJbRFzSbk=
MIME-Version: 1.0
In-Reply-To: <9ac0c6aa1002140245q11dd0205jf910c12dd2671f8@mail.gmail.com>
References: <786fde51002131216t68ffbc9aqddd8609aa0f22177@mail.gmail.com>
	 <9ac0c6aa1002140245q11dd0205jf910c12dd2671f8@mail.gmail.com>
Date: Mon, 15 Feb 2010 09:58:26 +0200
Message-ID: <786fde51002142358q7b9247a0k2701e10160c84c80@mail.gmail.com>
Subject: Re: IndexWriter.init() checks for infoStream != null, redundantly?
From: Shai Erera <serera@gmail.com>
To: java-dev@lucene.apache.org
Content-Type: multipart/alternative; boundary=000e0cd6704065a046047f9efb2f

--000e0cd6704065a046047f9efb2f
Content-Type: text/plain; charset=ISO-8859-1

Ok, didn't know about that. Thanks !

On Sun, Feb 14, 2010 at 12:45 PM, Michael McCandless <
lucene@mikemccandless.com> wrote:

> IndexWriter has a default infoStream, so the infoStream could be
> non-null during init.
>
> Mike
>
> On Sat, Feb 13, 2010 at 3:16 PM, Shai Erera <serera@gmail.com> wrote:
> > Hi
> >
> > IndexWriter.init() checks a couple of times whether infoStream != null in
> > order to print informative messages ... init() is called only from the
> > ctors, which means infoStream will always be null at this point, no?
> > Therefore I think those checks can be removed? Not for performance
> reasons,
> > but for clarity - no one should expect those messages to be printed out.
> >
> > BTW, would it make sense to add a ctor which accepts infoStream right
> from
> > the start, so that such messages will be printed out?
> >
> > I don't think an issue is needed (to remove the checks), however if there
> is
> > interest in adding a new ctor which accepts infoStream, then I can open
> one.
> > Even though I don't think those messages are really critical at this
> stage
> > of the system.
> >
> > Shai
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>

--000e0cd6704065a046047f9efb2f
Content-Type: text/html; charset=ISO-8859-1

<div dir="ltr">Ok, didn&#39;t know about that. Thanks !<br><br><div class="gmail_quote">On Sun, Feb 14, 2010 at 12:45 PM, Michael McCandless <span dir="ltr">&lt;<a href="mailto:lucene@mikemccandless.com">lucene@mikemccandless.com</a>&gt;</span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">IndexWriter has a default infoStream, so the infoStream could be<br>
non-null during init.<br>
<br>
Mike<br>
<div><div></div><div class="h5"><br>
On Sat, Feb 13, 2010 at 3:16 PM, Shai Erera &lt;<a href="mailto:serera@gmail.com">serera@gmail.com</a>&gt; wrote:<br>
&gt; Hi<br>
&gt;<br>
&gt; IndexWriter.init() checks a couple of times whether infoStream != null in<br>
&gt; order to print informative messages ... init() is called only from the<br>
&gt; ctors, which means infoStream will always be null at this point, no?<br>
&gt; Therefore I think those checks can be removed? Not for performance reasons,<br>
&gt; but for clarity - no one should expect those messages to be printed out.<br>
&gt;<br>
&gt; BTW, would it make sense to add a ctor which accepts infoStream right from<br>
&gt; the start, so that such messages will be printed out?<br>
&gt;<br>
&gt; I don&#39;t think an issue is needed (to remove the checks), however if there is<br>
&gt; interest in adding a new ctor which accepts infoStream, then I can open one.<br>
&gt; Even though I don&#39;t think those messages are really critical at this stage<br>
&gt; of the system.<br>
&gt;<br>
&gt; Shai<br>
&gt;<br>
<br>
</div></div>---------------------------------------------------------------------<br>
To unsubscribe, e-mail: <a href="mailto:java-dev-unsubscribe@lucene.apache.org">java-dev-unsubscribe@lucene.apache.org</a><br>
For additional commands, e-mail: <a href="mailto:java-dev-help@lucene.apache.org">java-dev-help@lucene.apache.org</a><br>
<br>
</blockquote></div><br></div>

--000e0cd6704065a046047f9efb2f--