Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 90169 invoked from network); 21 Feb 2010 19:27:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 21 Feb 2010 19:27:18 -0000 Received: (qmail 66888 invoked by uid 500); 21 Feb 2010 19:27:17 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 66803 invoked by uid 500); 21 Feb 2010 19:27:17 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 66795 invoked by uid 99); 21 Feb 2010 19:27:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 21 Feb 2010 19:27:17 +0000 X-ASF-Spam-Status: No, hits=3.4 required=10.0 tests=HTML_MESSAGE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [85.25.71.29] (HELO mail.troja.net) (85.25.71.29) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 21 Feb 2010 19:27:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.troja.net (Postfix) with ESMTP id 8C985D3600D for ; Sun, 21 Feb 2010 20:26:45 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.troja.net Received: from mail.troja.net ([127.0.0.1]) by localhost (megaira.troja.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i6ttVXF08IKt for ; Sun, 21 Feb 2010 20:26:41 +0100 (CET) Received: from VEGA (port-83-236-62-54.dynamic.qsc.de [83.236.62.54]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.troja.net (Postfix) with ESMTPSA id ABEAFD36008 for ; Sun, 21 Feb 2010 20:26:40 +0100 (CET) From: "Uwe Schindler" To: References: <359a92830911251832o5f58cff4xeac1cb4b8f4bcbb4mkm@mail.gmail.com> <359a92830911260738p478f3729i36867470886c6cc8@mail.gmail.com> <359a92830911270752m41b78055tf229ad97448740c3@mail.gmail.com> <9ac0c6aa0911271027x2c7a42edq981ad8688f0eda5@mail.gmail.com> <8f0ad1f31002131423r430f5ca1md3f283af1b5ba56d@mail.gmail.com> <9ac0c6aa1002140242n62c02ea8g45875c985420fa8b@mail.gmail.com> <000901caad63$f8a1a0b0$e9e4e210$@de> <8f0ad1f31002140327j10ffe96bu649067adda290a72@mail.gmail.com> <9ac0c6aa1002201445y2b34212eie4509f68fc09838d@mail.gmail.com> <8f0ad1f31002202310h6b525d6ax22d768d8c01a873a@mail.gmail.com> <8f0ad1f31002210153j3d97d48bv6b6664ea79b6ac23@mail.gmail.com> In-Reply-To: <8f0ad1f31002210153j3d97d48bv6b6664ea79b6ac23@mail.gmail.com> Subject: RE: (LUCENE-1844) Speed up junit tests Date: Sun, 21 Feb 2010 20:26:48 +0100 Message-ID: <000f01cab32b$d03350b0$7099f210$@de> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_000_0010_01CAB334.31F7B8B0" X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Acqy29S5maT4pCfvTWuwNGFi03AmEQAT703Q Content-Language: de ------=_NextPart_000_0010_01CAB334.31F7B8B0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Another test-bug that now shows as a real test failure (and not only in = stderr as before, thanks to LUCENE-2274). Happens quite often, will = check logs on Hudson, how often this happens. The test failure on my solaris box occurred in backwards branch of = trunk. =20 [junit] Testsuite: org.apache.lucene.store.TestRAMDirectory [junit] Tests run: 4, Failures: 1, Errors: 0, Time elapsed: 0.259 = sec [junit]=20 [junit] ------------- Standard Error ----------------- [junit] The following exceptions were thrown by threads: [junit] *** Thread: Thread-16978 *** [junit] junit.framework.AssertionFailedError: expected:<84992> but = was:<86016> [junit] at junit.framework.Assert.fail(Assert.java:47) [junit] at junit.framework.Assert.failNotEquals(Assert.java:277) [junit] at junit.framework.Assert.assertEquals(Assert.java:64) [junit] at junit.framework.Assert.assertEquals(Assert.java:130) [junit] at junit.framework.Assert.assertEquals(Assert.java:136) [junit] at = org.apache.lucene.store.TestRAMDirectory$1.run(TestRAMDirectory.java:129)= [junit] ------------- ---------------- --------------- [junit] Testcase: = testRAMDirectorySize(org.apache.lucene.store.TestRAMDirectory): FAILED [junit] Some threads throwed uncaught exceptions! [junit] junit.framework.AssertionFailedError: Some threads throwed = uncaught exceptions! [junit] at = org.apache.lucene.util.LuceneTestCase.tearDown(LuceneTestCase.java:142) [junit] at = org.apache.lucene.store.TestRAMDirectory.tearDown(TestRAMDirectory.java:1= 60) [junit] at = org.apache.lucene.util.LuceneTestCase.runBare(LuceneTestCase.java:250) [junit]=20 [junit]=20 [junit] TEST org.apache.lucene.store.TestRAMDirectory FAILED =20 ----- Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: uwe@thetaphi.de =20 From: Robert Muir [mailto:rcmuir@gmail.com]=20 Sent: Sunday, February 21, 2010 10:53 AM To: java-dev@lucene.apache.org Subject: Re: (LUCENE-1844) Speed up junit tests =20 here is what i was worried about, if we cannot fix, i can revert back to = forking. This is not reproduceable all the time: [junit] Testcase: = testParallelMultiSort(org.apache.lucene.search.TestSort): Caused an = ERROR [junit] java.util.ConcurrentModificationException [junit] java.lang.RuntimeException: = java.util.ConcurrentModificationException [junit] at = org.apache.lucene.search.ParallelMultiSearcher.foreach(ParallelMultiSearc= her.java:216) [junit] at = org.apache.lucene.search.ParallelMultiSearcher.search(ParallelMultiSearch= er.java:121) [junit] at = org.apache.lucene.search.Searcher.search(Searcher.java:49) [junit] at = org.apache.lucene.search.TestSort.assertMatches(TestSort.java:965) [junit] at = org.apache.lucene.search.TestSort.runMultiSorts(TestSort.java:891) [junit] at = org.apache.lucene.search.TestSort.testParallelMultiSort(TestSort.java:629= ) [junit] at = org.apache.lucene.util.LuceneTestCase.runBare(LuceneTestCase.java:208) [junit] Caused by: java.util.ConcurrentModificationException [junit] at = java.util.WeakHashMap$HashIterator.nextEntry(WeakHashMap.java:762) [junit] at = java.util.WeakHashMap$KeyIterator.next(WeakHashMap.java:795) [junit] at = org.apache.lucene.search.FieldCacheImpl.getCacheEntries(FieldCacheImpl.ja= va:75) [junit] at = org.apache.lucene.util.FieldCacheSanityChecker.checkSanity(FieldCacheSani= tyChecker.java:72) [junit] at = org.apache.lucene.search.FieldCacheImpl$Cache.printNewInsanity(FieldCache= Impl.java:205) [junit] at = org.apache.lucene.search.FieldCacheImpl$Cache.get(FieldCacheImpl.java:194= ) [junit] at = org.apache.lucene.search.FieldCacheImpl.getInts(FieldCacheImpl.java:357) [junit] at = org.apache.lucene.search.FieldCacheImpl$IntCache.createValue(FieldCacheIm= pl.java:373) [junit] at = org.apache.lucene.search.FieldCacheImpl$Cache.get(FieldCacheImpl.java:183= ) [junit] at = org.apache.lucene.search.FieldCacheImpl.getInts(FieldCacheImpl.java:357) [junit] at = org.apache.lucene.search.FieldComparator$IntComparator.setNextReader(Fiel= dComparator.java:438) [junit] at = org.apache.lucene.search.TopFieldCollector$OneComparatorNonScoringCollect= or.setNextReader(TopFieldCollector.java:95) [junit] at = org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:207) [junit] at = org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:197) [junit] at = org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:175) [junit] at = org.apache.lucene.search.MultiSearcher$MultiSearcherCallableWithSort.call= (MultiSearcher.java:420) [junit] at = org.apache.lucene.search.MultiSearcher$MultiSearcherCallableWithSort.call= (MultiSearcher.java:394) [junit] at = java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) [junit] at = java.util.concurrent.FutureTask.run(FutureTask.java:138) [junit] at = java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor= .java:886) [junit] at = java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.jav= a:908) [junit] at java.lang.Thread.run(Thread.java:619) [junit] [junit] [junit] TEST org.apache.lucene.search.TestSort FAILED On Sun, Feb 21, 2010 at 2:10 AM, Robert Muir wrote: ok, can do. if it turns out there is a problem, we can revert until some = work has been done on the tests. =20 On Sat, Feb 20, 2010 at 5:45 PM, Michael McCandless = wrote: Currently the tests run 1 jvm per test suite (eg, TestIndexWriter has its own jvm), I believe, and we haven't seen test failures... so I think for the most part tests are not interfering with each other (messing up global state). It should be less likely that we see interactions across test suites (but obviously still possible). I think we should commit this and then if there are somehow problems we can address them, then? Mike On Sun, Feb 14, 2010 at 6:27 AM, Robert Muir wrote: > its not just statics, I think we should really look at ensuring files = are > closed etc, or eventually there will be a problem! > > I guess in general the tradeoff is, it requires us to have better test = code. > > On Sun, Feb 14, 2010 at 5:53 AM, Uwe Schindler = wrote: >> >> At least we should check all core tests to not set any static = defaults >> without try...finally! Are there any possibilities inside = Eclipse/other-IDEs >> to check this? >> >> Uwe >> >> ----- >> Uwe Schindler >> H.-H.-Meier-Allee 63, D-28213 Bremen >> http://www.thetaphi.de >> eMail: uwe@thetaphi.de >> >> > -----Original Message----- >> > From: Michael McCandless [mailto:lucene@mikemccandless.com] >> > Sent: Sunday, February 14, 2010 11:43 AM >> > To: java-dev@lucene.apache.org >> > Subject: Re: (LUCENE-1844) Speed up junit tests >> > >> > Wow -- this is MUCH faster! I think we should switch... >> > >> > It seems like we use a batchtest for all core tests, then for all >> > back-compat tests, then once per contrib package? Ie, so "ant >> > test-core" uses one jvm? >> > >> > I think we should simply fix any badly behaved tests (that don't >> > restore statics). It's impressive we already have no test failures >> > when we do this... I guess our tests are already cleaning things up >> > (though also probably not often changing global state, or, changing = it >> > in a way that'd lead other tests to fail). >> > >> > Mike >> > >> > On Sat, Feb 13, 2010 at 5:23 PM, Robert Muir = wrote: >> > > On Fri, Nov 27, 2009 at 1:27 PM, Michael McCandless >> > > wrote: >> > >> >> > >> Also one thing I'd love to try is NOT forking the JVM for each = test >> > >> (fork=3D"no" in the junit task). I wonder how much time that'd = buy... >> > >> >> > > >> > > it shaves off a good deal of time on my machine. >> > > >> > > 'ant test-core': 4 minutes, 39 seconds -> 3 minutes, 3 seconds >> > > 'ant test': 11 minutes, 8 seconds -> 7 minutes, 13 seconds >> > > >> > > however, it makes me a little nervous because i'm not sure all = the >> > tests >> > > cleanup nicely if they change statics and stuff. >> > > anyway, here's the trivial patch (you don't want fork=3Dno, = because it >> > turns >> > > off assertions) >> > > >> > > Index: common-build.xml >> > > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> > > --- common-build.xml (revision 909395) >> > > +++ common-build.xml (working copy) >> > > @@ -398,7 +398,7 @@ >> > > >> > > >> > > > > maxmemory=3D"512M" >> > > - errorProperty=3D"tests.failed" >> > failureProperty=3D"tests.failed"> >> > > + errorProperty=3D"tests.failed" >> > failureProperty=3D"tests.failed" >> > > forkmode=3D"perBatch"> >> > > >> > > >> > > >> > > >> > > -- >> > > Robert Muir >> > > rcmuir@gmail.com >> > > >> > >> > = --------------------------------------------------------------------- >> > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org >> > For additional commands, e-mail: java-dev-help@lucene.apache.org >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org >> For additional commands, e-mail: java-dev-help@lucene.apache.org >> > > > > -- > Robert Muir > rcmuir@gmail.com > --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org --=20 Robert Muir rcmuir@gmail.com --=20 Robert Muir rcmuir@gmail.com ------=_NextPart_000_0010_01CAB334.31F7B8B0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Another test-bug that now shows as a real test failure = (and not only in stderr as before, thanks to LUCENE-2274). Happens quite often, = will check logs on Hudson, how often this happens.

The test failure on my solaris box occurred in backwards = branch of trunk.

 

=C2=A0=C2=A0=C2=A0 [junit] Testsuite: = org.apache.lucene.store.TestRAMDirectory

=C2=A0=C2=A0=C2=A0 [junit] Tests run: 4, Failures: 1, = Errors: 0, Time elapsed: 0.259 sec

=C2=A0=C2=A0=C2=A0 [junit]

=C2=A0=C2=A0=C2=A0 [junit] ------------- Standard Error = -----------------

=C2=A0=C2=A0=C2=A0 [junit] The following exceptions were = thrown by threads:

=C2=A0=C2=A0=C2=A0 [junit] *** Thread: Thread-16978 = ***

=C2=A0=C2=A0=C2=A0 [junit] = junit.framework.AssertionFailedError: expected:<84992> but was:<86016>

=C2=A0=C2=A0=C2=A0 [junit]=C2=A0=C2=A0=C2=A0=C2=A0 at = junit.framework.Assert.fail(Assert.java:47)

=C2=A0=C2=A0=C2=A0 [junit]=C2=A0=C2=A0=C2=A0=C2=A0 at junit.framework.Assert.failNotEquals(Assert.java:277)

=C2=A0=C2=A0=C2=A0 [junit]=C2=A0=C2=A0=C2=A0=C2=A0 at junit.framework.Assert.assertEquals(Assert.java:64)

=

=C2=A0=C2=A0=C2=A0 [junit]=C2=A0=C2=A0=C2=A0=C2=A0 at = junit.framework.Assert.assertEquals(Assert.java:130)

=C2=A0=C2=A0=C2=A0 [junit]=C2=A0=C2=A0=C2=A0=C2=A0 at junit.framework.Assert.assertEquals(Assert.java:136)

=C2=A0=C2=A0=C2=A0 [junit]=C2=A0=C2=A0=C2=A0=C2=A0 at org.apache.lucene.store.TestRAMDirectory$1.run(TestRAMDirectory.java:129)=

=C2=A0=C2=A0=C2=A0 [junit] ------------- ---------------- = ---------------

=C2=A0=C2=A0=C2=A0 [junit] Testcase: testRAMDirectorySize(org.apache.lucene.store.TestRAMDirectory):=C2=A0=C2=A0= FAILED

=C2=A0=C2=A0=C2=A0 [junit] Some threads throwed uncaught = exceptions!

=C2=A0=C2=A0=C2=A0 [junit] = junit.framework.AssertionFailedError: Some threads throwed uncaught exceptions!

=C2=A0=C2=A0=C2=A0 [junit]=C2=A0=C2=A0=C2=A0 =C2=A0at org.apache.lucene.util.LuceneTestCase.tearDown(LuceneTestCase.java:142)

=C2=A0=C2=A0=C2=A0 [junit]=C2=A0=C2=A0=C2=A0=C2=A0 at org.apache.lucene.store.TestRAMDirectory.tearDown(TestRAMDirectory.java:1= 60)

=C2=A0=C2=A0=C2=A0 [junit]=C2=A0=C2=A0=C2=A0=C2=A0 at org.apache.lucene.util.LuceneTestCase.runBare(LuceneTestCase.java:250)

=C2=A0=C2=A0=C2=A0 [junit]

=C2=A0=C2=A0=C2=A0 [junit]

=C2=A0=C2=A0=C2=A0 [junit] TEST = org.apache.lucene.store.TestRAMDirectory FAILED

 

-----

Uwe Schindler

H.-H.-Meier-Allee 63, D-28213 = Bremen

http://www.thetaphi.de<= /p>

eMail: uwe@thetaphi.de

 

From:= Robert = Muir [mailto:rcmuir@gmail.com]
Sent: Sunday, February 21, 2010 10:53 AM
To: java-dev@lucene.apache.org
Subject: Re: (LUCENE-1844) Speed up junit = tests

 

here is what i was = worried about, if we cannot fix, i can revert back to forking. This is not reproduceable all the time:

    [junit] Testcase: testParallelMultiSort(org.apache.lucene.search.TestSort): Caused an = ERROR
    [junit] java.util.ConcurrentModificationException
    [junit] java.lang.RuntimeException: java.util.ConcurrentModificationException
    [junit]     at org.apache.lucene.search.ParallelMultiSearcher.foreach(ParallelMultiSearc= her.java:216)
    [junit]     at org.apache.lucene.search.ParallelMultiSearcher.search(ParallelMultiSearch= er.java:121)
    [junit]     at org.apache.lucene.search.Searcher.search(Searcher.java:49)
    [junit]     at org.apache.lucene.search.TestSort.assertMatches(TestSort.java:965)
    [junit]     at org.apache.lucene.search.TestSort.runMultiSorts(TestSort.java:891)
    [junit]     at org.apache.lucene.search.TestSort.testParallelMultiSort(TestSort.java:629= )
    [junit]     at org.apache.lucene.util.LuceneTestCase.runBare(LuceneTestCase.java:208)     [junit] Caused by: = java.util.ConcurrentModificationException
    [junit]     at java.util.WeakHashMap$HashIterator.nextEntry(WeakHashMap.java:762)
    [junit]     at java.util.WeakHashMap$KeyIterator.next(WeakHashMap.java:795)
    [junit]     at org.apache.lucene.search.FieldCacheImpl.getCacheEntries(FieldCacheImpl.ja= va:75)
    [junit]     at org.apache.lucene.util.FieldCacheSanityChecker.checkSanity(FieldCacheSani= tyChecker.java:72)
    [junit]     at org.apache.lucene.search.FieldCacheImpl$Cache.printNewInsanity(FieldCache= Impl.java:205)
    [junit]     at org.apache.lucene.search.FieldCacheImpl$Cache.get(FieldCacheImpl.java:194= )
    [junit]     at org.apache.lucene.search.FieldCacheImpl.getInts(FieldCacheImpl.java:357)<= br>     [junit]     at = org.apache.lucene.search.FieldCacheImpl$IntCache.createValue(FieldCacheIm= pl.java:373)
    [junit]     at org.apache.lucene.search.FieldCacheImpl$Cache.get(FieldCacheImpl.java:183= )
    [junit]     at org.apache.lucene.search.FieldCacheImpl.getInts(FieldCacheImpl.java:357)<= br>     [junit]     at org.apache.lucene.search.FieldComparator$IntComparator.setNextReader(Fiel= dComparator.java:438)
    [junit]     at org.apache.lucene.search.TopFieldCollector$OneComparatorNonScoringCollect= or.setNextReader(TopFieldCollector.java:95)
    [junit]     at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:207)
=     [junit]     at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:197)
=     [junit]     at org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:175)
=     [junit]     at org.apache.lucene.search.MultiSearcher$MultiSearcherCallableWithSort.call= (MultiSearcher.java:420)
    [junit]     at org.apache.lucene.search.MultiSearcher$MultiSearcherCallableWithSort.call= (MultiSearcher.java:394)
    [junit]     at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
    [junit]     at java.util.concurrent.FutureTask.run(FutureTask.java:138)
    [junit]     at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor= .java:886)
    [junit]     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.jav= a:908)
    [junit]     at java.lang.Thread.run(Thread.java:619)
    [junit]
    [junit]
    [junit] TEST org.apache.lucene.search.TestSort = FAILED

On Sun, Feb 21, 2010 at 2:10 AM, Robert Muir <rcmuir@gmail.com> = wrote:

ok, can do. if it turns out there is a problem, we = can revert until some work has been done on the tests.

 

On Sat, Feb 20, 2010 at 5:45 PM, Michael McCandless = <lucene@mikemccandless.com> wrote:

Currently the tests run 1 jvm per test suite (eg, TestIndexWriter has
its own jvm), I believe, and we haven't seen test failures... so I
think for the most part tests are not interfering with each other
(messing up global state).

It should be less likely that we see interactions across test suites
(but obviously still possible).

I think we should commit this and then if there are somehow problems
we can address them, then?

Mike


On Sun, Feb 14, 2010 at 6:27 AM, Robert Muir <rcmuir@gmail.com> wrote:
> its not just statics, I think we should really look at ensuring = files are
> closed etc, or eventually there will be a problem!
>
> I guess in general the tradeoff is, it requires us to have better = test code.
>
> On Sun, Feb 14, 2010 at 5:53 AM, Uwe Schindler <uwe@thetaphi.de> wrote:
>>
>> At least we should check all core tests to not set any static = defaults
>> without try...finally! Are there any possibilities inside Eclipse/other-IDEs
>> to check this?
>>
>> Uwe
>>
>> -----
>> Uwe Schindler
>> H.-H.-Meier-Allee 63, D-28213 Bremen
>> http://www.thetaphi.de
>> eMail: uwe@thetaphi.de
>>
>> > -----Original Message-----
>> > From: Michael McCandless [mailto:lucene@mikemccandless.com]
>> > Sent: Sunday, February 14, 2010 11:43 AM
>> > To: java-dev@lucene.apache.org
>> > Subject: Re: (LUCENE-1844) Speed up junit tests
>> >
>> > Wow -- this is MUCH faster!  I think we should = switch...
>> >
>> > It seems like we use a batchtest for all core tests, then = for all
>> > back-compat tests, then once per contrib package? =  Ie, so "ant
>> > test-core" uses one jvm?
>> >
>> > I think we should simply fix any badly behaved tests (that = don't
>> > restore statics).  It's impressive we already have no = test failures
>> > when we do this... I guess our tests are already cleaning = things up
>> > (though also probably not often changing global state, or, changing it
>> > in a way that'd lead other tests to fail).
>> >
>> > Mike
>> >
>> > On Sat, Feb 13, 2010 at 5:23 PM, Robert Muir <rcmuir@gmail.com> wrote:
>> > > On Fri, Nov 27, 2009 at 1:27 PM, Michael = McCandless
>> > > <lucene@mikemccandless.com> wrote:
>> > >>
>> > >> Also one thing I'd love to try is NOT forking the = JVM for each test
>> > >> (fork=3D"no" in the junit task). =  I wonder how much time that'd buy...
>> > >>
>> > >
>> > > it shaves off a good deal of time on my machine.
>> > >
>> > > 'ant test-core': 4 minutes, 39 seconds -> 3 = minutes, 3 seconds
>> > > 'ant test':  11 minutes, 8 seconds -> 7 = minutes, 13 seconds
>> > >
>> > > however, it makes me a little nervous because i'm not = sure all the
>> > tests
>> > > cleanup nicely if they change statics and stuff.
>> > > anyway, here's the trivial patch (you don't want = fork=3Dno, because it
>> > turns
>> > > off assertions)
>> > >
>> > > Index: common-build.xml
>> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> > > --- common-build.xml    (revision = 909395)
>> > > +++ common-build.xml    (working copy)
>> > > @@ -398,7 +398,7 @@
>> > >             = </condition>
>> > >               =   <mkdir dir=3D"@{junit.output.dir}"/>
>> > >             <junit printsummary=3D"off" haltonfailure=3D"no"
>> > maxmemory=3D"512M"
>> > > -             errorProperty=3D"tests.failed"
>> > failureProperty=3D"tests.failed">
>> > > +             errorProperty=3D"tests.failed"
>> > failureProperty=3D"tests.failed"
>> > > forkmode=3D"perBatch">
>> > >               <classpath refid=3D"@{junit.classpath}"/>
>> > >               <assertions>
>> > >               =   <enable package=3D"org.apache.lucene"/>
>> > >
>> > > --
>> > > Robert Muir
>> > > rcmuir@gmail.com
>> > >
>> >
>> > ---------------------------------------------------------------------
= >> > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> > For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>
>>
>> = ---------------------------------------------------------------------
= >> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>
>
>
> --
> Robert Muir
> rcmuir@gmail.com
>

---------------------------------------------------------------------
= To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org



--

Robert Muir
rcmuir@gmail.com




--
Robert Muir
rcmuir@gmail.com

------=_NextPart_000_0010_01CAB334.31F7B8B0--